Skip to content

RC: fix internal API nullability issue caught by analyzer #13712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

RC: fix internal API nullability issue caught by analyzer #13712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion FirebaseRemoteConfig/Sources/Private/RCNConfigFetch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ typedef void (^RCNConfigFetchCompletion)(FIRRemoteConfigFetchStatus status,
/// @param expirationDuration Expiration duration, in seconds.
/// @param completionHandler Callback handler.
- (void)fetchConfigWithExpirationDuration:(NSTimeInterval)expirationDuration
completionHandler:(FIRRemoteConfigFetchCompletion)completionHandler;
completionHandler:
(_Nullable FIRRemoteConfigFetchCompletion)completionHandler;

/// Fetches config data immediately, keyed by namespace. Completion block will be called on the main
/// queue.
Expand Down
3 changes: 2 additions & 1 deletion FirebaseRemoteConfig/Sources/RCNConfigFetch.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ - (void)dealloc {
#pragma mark - Fetch Config API

- (void)fetchConfigWithExpirationDuration:(NSTimeInterval)expirationDuration
completionHandler:(FIRRemoteConfigFetchCompletion)completionHandler {
completionHandler:
(_Nullable FIRRemoteConfigFetchCompletion)completionHandler {
// Note: We expect the googleAppID to always be available.
BOOL hasDeviceContextChanged =
FIRRemoteConfigHasDeviceContextChanged(_settings.deviceContext, _options.googleAppID);
Expand Down