[Vertex AI] Cleanup Decodable impl from BlockThreshold #13673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheard
changed the title
init(from: Decoder) from BlockThreshold
paulb777
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the extraneous
public init(from decoder: Decoder) throwsimplementation fromSafetySetting.BlockThreshold. This type is nowEncodable-only as of #13666 since it is only used in requests.Removed extraneous cases
unknownandunspecifiedfrom theBlockThresholdenum. Considering this non-breaking since any requests usingunknownorunspecifiedwill results in errors from the backend.#no-changelog