Skip to content

[Auth] Better keychain error descriptions #13600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2024
Merged

[Auth] Better keychain error descriptions #13600

merged 3 commits into from
Sep 6, 2024

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 6, 2024

  • Add description string to generated keychain errors
  • Use public API to set shared keychain instead of internal one in sample

@google-oss-bot
Copy link

google-oss-bot commented Sep 6, 2024

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3
Copy link
Member

ncooke3 commented Sep 6, 2024 •
edited
Loading

check failure:

scripts/style.sh FirebaseAuth/Tests/SampleSwift/AuthenticationExample/ViewControllers/SettingsViewController.swift

@paulb777 paulb777 merged commit ed4269b into main Sep 6, 2024
@paulb777 paulb777 deleted the pb-better-keychain-errors branch September 6, 2024 19:05
This was referenced Sep 30, 2024
Closed
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

No one assigned

Labels

api: auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @google-oss-bot @ncooke3