Skip to content

Add -Wno-error=redundant-move to cmake builds #13582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add -Wno-error=redundant-move to cmake builds #13582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cmake/compiler_setup.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

include(CheckCXXCompilerFlag)

# C++ Compiler setup

# We use C++14
Expand Down Expand Up @@ -76,6 +78,14 @@ if(CXX_CLANG OR CXX_GNU)
list(APPEND common_flags -fdiagnostics-color)
endif()
endif()

# Disable treating "redundant-move" as an error since it's not really a problem,
# and is even a valid coding style to over-use std::move() in case the type is
# ever changed to become non-trivially moveable.
CHECK_CXX_COMPILER_FLAG("-Wno-error=redundant-move" FIREBASE_CXX_COMPILER_FLAG_REDUNDANT_MOVE_SUPPORTED)
if(FIREBASE_CXX_COMPILER_FLAG_REDUNDANT_MOVE_SUPPORTED)
list(APPEND common_flags -Wno-error=redundant-move)
endif()
endif()

if(APPLE)
Expand Down