-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Sessions] Initial commit of Firebase Sessions SDK #10285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working through the DD... but here's a first pass!
Thanks for the suggestions @ncooke3 ! Added my responses. |
CI should be fixed by a rebase on top of |
9c8c297
to
30bbe0e
Compare
@samedson, sorry– I thought the rebase would surely fix CI. It's not a blocker though since the failure is unrelated. |
1ac7495
to
f5b5504
Compare
f5b5504
to
b9195ef
Compare
Sounds good - thanks for the advice! I made one change to include a reference to the Google App ID because we'll need that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While starting with CocoaPods is ok, it might be better to do early development in Swift Package Manager, since it's the future.
Paired with: @jeremyjiang-dev
Notes
Questions
functions(...
protocol method is being calledComponent
constructor#no-changelog
#sessions