Skip to content

Add IndexBackfiller to Support Client Side Indexing #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2022
Merged

Add IndexBackfiller to Support Client Side Indexing #10021

merged 3 commits into from
Jul 30, 2022

Conversation

cherylEnkidu
Copy link
Contributor

#no-changelog

@google-oss-bot
Copy link

google-oss-bot commented Jul 18, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (bc2bc6b)Merge (c23579b)Diff
    CocoaPods6.94 MB6.94 MB+632 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZqooyAg9z1.html

@google-oss-bot
Copy link

google-oss-bot commented Jul 18, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.37% (bc2bc6b) to 88.55% (c23579b) by +0.18%.

    FilenameBase (bc2bc6b)Merge (c23579b)Diff
    firestore_client.cc98.77%98.81%+0.04%
    index_backfiller.cc?100.00%?
    leveldb_index_manager.cc93.11%96.17%+3.06%
    leveldb_remote_document_cache.cc90.34%94.38%+4.03%
    local_documents_view.cc96.50%96.83%+0.33%
    memory_index_manager.cc43.94%48.48%+4.55%
    ordered_code.cc93.90%94.39%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eGvDp3BLwM.html

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/IndexBackfiller branch 2 times, most recently from 7590f90 to d74c04b Compare July 18, 2022 13:43
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/IndexBackfiller branch from d74c04b to 697be25 Compare July 19, 2022 13:25
@cherylEnkidu cherylEnkidu requested a review from wu-hui July 19, 2022 13:25
wu-hui
wu-hui reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed the tests yet, want to give you a first round of feedback.

@wu-hui wu-hui assigned cherylEnkidu and unassigned wu-hui Jul 22, 2022
@cherylEnkidu cherylEnkidu assigned wu-hui and unassigned cherylEnkidu Jul 29, 2022
wu-hui
wu-hui approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some nits, great work!!

@wu-hui wu-hui assigned cherylEnkidu and unassigned wu-hui Jul 29, 2022
@cherylEnkidu cherylEnkidu merged commit 9b4c200 into master Jul 30, 2022
@cherylEnkidu cherylEnkidu deleted the cheryllin/IndexBackfiller branch July 30, 2022 00:05
@firebase firebase locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@Eldeloro1 Eldeloro1 Eldeloro1 approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherylEnkidu @google-oss-bot @wu-hui @Eldeloro1