Build error in FirebaseCoreDiagnostics >= 7.2.0

[mikehardy]

Step 0: Are you in the right place?

• For issues or feature requests related to the code in this repository
  file a Github issue.
  • If this is a feature request please use the Feature Request template.
• For general technical questions, post a question on StackOverflow
  with the firebase tag.
• For general (non-iOS) Firebase discussion, use the firebase-talk
  google group.
• For backend issues, console issues, and other non-SDK help that does not fall under one
  of the above categories, reach out to
  Firebase Support.
• Once you've read this section and determined that your issue is appropriate for
  this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

• Xcode version: 12.2
• Firebase SDK version: 7.1.0, 7.2.0
• Installation method: CocoaPods
• Firebase Component: FirebaseCoreDiagnostics dependents (Auth, InAppMessaging, RemoteConfig etc)

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

I think there may be two issues, related. Both have the same ultimate build error

1. Pod dependency issues:

When 7.1.0 was originally released, everything built fine. Now with 7.2.0 out, 7.1.0 no longer builds correctly.

I believe some of the podspecs allow a few of the transitive dependencies to slip the bonds of the requested version (7.1.0) and move to 7.2.0. Specifically, these pods will go to 7.2.0 on a fresh install of 7.1.0 Firebase/* pods - here's a snippet from where I was pinning them in my test app Podfile to see what Podfile.lock would look like - each would go to 7.2.0 (or 7.2.0-beta for FirebaseMLCommon) despite a request for the related 7.1.0 Pods (e.g. 'Firebase/InstanceID', $FirebaseSDKVersion with 7.1.0 would get me `FirebaseInstanceID of 7.2.0. In fact, this seems to happen even if I try 7.0.0 now because it is still semver compatible with 7.2.0 according to the version constraints.

  #pod 'FirebaseABTesting', $FirebaseSDKVersion
  #pod 'FirebaseCoreDiagnostics', $FirebaseSDKVersion
  #pod 'FirebaseInstallations', $FirebaseSDKVersion
  #pod 'FirebaseInstanceID', $FirebaseSDKVersion
  #pod 'FirebaseMLCommon', "#{$FirebaseSDKVersion}-beta"

2. Build error in FirebaseCoreDiagnostics >= 7.2.0

❌  /Users/mike/work/Invertase/react-native-firebase/tests/ios/Pods/FirebaseCoreDiagnostics/Firebase/CoreDiagnostics/FIRCDLibrary/FIRCoreDiagnostics.m:20:9: 'GoogleDataTransport/GDTCORLibrary/Internal/GoogleDataTransportInternal.h' file not found

#import "GoogleDataTransport/GDTCORLibrary/Internal/GoogleDataTransportInternal.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Normally I would trust the internal versioning to be okay, but in this case the rest of the internal 7.2.0 changes are fine except FirebaseCoreDiagnostics. That one has a build error as above.

When I try to use 7.2.0 completely - which I was testing after fixing a firestore compile issue this morning - it still fails.

I maintain a fully scripted react-native-firebase demonstrator where you can see how we construct a clean project and add our dependencies, then investigate the resulting Podfile - it fails to compile now with 7.x.x

https://github.com/mikehardy/rnfbdemo/blob/master/make-demo.sh

You'll need node + yarn installed to run it, plus a 'GoogleServices-plist.json' and 'google-services.json' to your favorite example project (they're unused unless you run the demo and even then the demo doesn't actually do anything other than prove it builds and runs, if you're curious)

I'm not sure what the root cause of the error is but I reproduce it in FlutterFire (where I'm trying to get firebase-ios-sdk >=7 supported - firebase/flutterfire#4249), my work app, and react-native-firebase which I maintain and normally know what I'm doing, except when a hit a build error and feel lost ;-). Our test app no longer works unless I use 7.1.0 and in our app Podfile pin FirebaseCoreDiagnostics to 7.1.0

Help?

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[mikehardy]

@paulb777 / @ryanwilson not in the habit of tagging people in lightly but I know you just worked on the release since I collaborated a moment with Paul this morning, and I did as much pre-diagnostics as I could. This blocks use of 7.2.0 for me in react-native-firebase and flutterfire where I would otherwise work to advance your new APIs :-), and the only workaround for 7.x.x at all is to use an unexpected version override of an internal pod.

Thought you might want to take a look since I think I may be trailblazing on adoption of 7.2.0 here

[paulb777]

@mikehardy Appreciate the heads-up. I'll take a look this afternoon.

[paulb777]

@mikehardy Would you share the generated Podfile.lock

[mikehardy]

Sure, to be precise, you would like to see the generated Podfile.lock with 7.1.0 specified (to see the 7.2.0s that slip in?). I'm guessing yes and will start executing that

[paulb777]

It should be ok for 7.2.0's to slip in, but yes - I'd like to see the exact problem.

Meanwhile I'm trying to run the script you sent ...

[mikehardy]

Here's what my Podfile.lock looks like from that script (for avoidance of doubt, the script had 7.1.0 specified as the Pod version to use in react-native-firebase, which then propagates throughout the first-level Pod dependencies on a module-per-module basis from the react-native-firebase wrapper to the underlying firebase-ios-sdk pod dep)

Podfile.lock.txt

[mikehardy]

Here is just the diff that shows what happens if I delete Podfile.lock then re-run pod install on my work project. Previous lock was done on Nov 30 according to git history

(my paste from a vscode ssh session was bogus, replacing with file direct copied)

Podfile.lock.diff.txt

[paulb777]

I'm still trying to get your repro set up. Nothing should have changed in the those versions that changed from 7.1 to 7.2. It might be interesting to compare the two Pods directories.

The missing file should be at Pods/FirebaseCoreDiagnostics/GoogleDataTransport/GDTCORLibrary/Internal/GoogleDataTransportInternal.h in both versions.

[paulb777]

After installing some stuff, the script runs for awhile and fails with:

+ cp -r ../rnfbdemo.xcodeproj ios/
cp: ../rnfbdemo.xcodeproj: No such file or directory

A Podfile.lock is generated but doesn't include any Firebase pods.

[mikehardy]

Indeed, the header file appears to exist, it's confounding. I saw some PRs and all sorts of noise about moving GoogleDataTransport headers internal and stuff, but that seems like a red herring. I believe it was prior to this problem and the header ref is already internal.

...that error is odd, I mostly run the script on macOS or Linux and I'd assume your macOS since it's a firebase-ios-sdk issue ;-). I just spun up a new Big Sur VM last night so this was all clean runs for me this morning from a fresh checkout of git@github.com:mikehardy/rnfbdemo.git - I'm normally in the business of clean repro so I thought a fully scripted one would be perfect.

You can also try cloning react-native-firebase and following the instructions for it https://github.com/invertase/react-native-firebase/blob/master/tests/README.md

for the purposes of demonstration it should just be, from root level there, post checkout:

yarn
yarn tests:ios:pod:install
yarn tests:ios:build

(if you use that one and pin FirebaseCoreDiagnostics to 7.1.0 it will mostly build but then fail on the firestore-ios-sdk-frameworks having a symbol collision on leveldb - this is unrelated, and at the expense of a greater compile time just comment out the FirebaseFirestore reference in tests/ios/Podfile and re-pod install re-build - it's not something I'm pursuing at the moment)