-
Notifications
You must be signed in to change notification settings - Fork 213
Add support for VPC connectors in functions.runWith
#752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VPC connectors in functions.runWith
#752
Conversation
fbb1170
to
f76bfe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this! One small change but overall looks good.
Note that the internal API review process needs to complete before we can merge / release this. I'll come back around when that's done.
d9ecac1
to
4227bd0
Compare
4227bd0
to
4552ac4
Compare
It looks like the Google Cloud console UI for editing cloud functions is currently broken for Firebase functions, which makes it impossible to assign a VPC connector to a Firebase function right now, so it'd be great to get this merged and avoid having to use that fragile UI forevermore. |
If someone still stucked into this, i built a gcloud function (who works with gcloud console or gcloud cli to assign the vpc) to act like a "proxy" routing out egress traffic with a vpc connector. And i call this proxy function from my firebase functions when need to use the vpc. I know its very aweful but there no way to do this direct in firebase by now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out in conjunction with firebase/firebase-tools#2525 and it worked great!
functions.runWith
Hi, Just found on your code changes. If someone is looking for that you can find here: Thnx |
Description
This PR adds support for vpcConnectors inside runWith.
Refers to #552 and my corresponding PR in firebase-tools: #2525
Code sample