Skip to content

Fix bug where function configuration with null couldn't be deployed. #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taeold merged 2 commits into from
Sep 29, 2022
Merged

Fix bug where function configuration with null couldn't be deployed. #1246

taeold merged 2 commits into from
Sep 29, 2022

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Sep 29, 2022 •
edited
Loading 

> (typeof null === "object")
true

@taeold taeold requested a review from Berlioz September 29, 2022 22:51
Berlioz
Berlioz approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@Berlioz Berlioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. +1

@taeold taeold merged commit cc6e28e into master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Berlioz Berlioz Berlioz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taeold @Berlioz