Add support for secrets in v2 #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
approved these changes
Apr 20, 2022
inlined
approved these changes
Apr 25, 2022
Member
inlined
left a comment
inlined
left a comment
There was a problem hiding this comment.
I personally wouldn't have moved HttpsOptions
src/v2/options.ts
Outdated
| opts, | ||
| 'secretEnvironmentVariables', | ||
| 'secrets', | ||
| (secrets) => secrets.map((secret) => ({ secret, key: secret })) |
Member
There was a problem hiding this comment.
I'm confused. Isn't this specifying both the env var and the secret name? DIdn't we not want to do that in the SDK but in the CLI since (in the future) the build process needs to not set the secret name so that extensions can?
colerogers
requested changes
Apr 26, 2022
jhuleatt
reviewed
Apr 28, 2022
colerogers
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to adding secrets to v2
__endpointannotation, I'm also making following (small) changes:platformbe part of trigger annotation - Firebase CLI already assumes that it's included.