error TS2315: Type 'Response' is not generic when upgrading to 3.4.0

[tianhaoz95]

Related issues

[REQUIRED] Version info

node:10.16.0

firebase-functions:3.4.0

firebase-tools:7.15.1

firebase-admin:8.10.0

[REQUIRED] Test case

Doesn't build with tsc.

[REQUIRED] Steps to reproduce

Initialize with a hello world TypeScript example, and do tsc.

[REQUIRED] Expected behavior

It should build the code in src.

[REQUIRED] Actual behavior

##[error]node_modules/firebase-functions/lib/function-builder.d.ts(59,57): error TS2315: Type 'Response' is not generic.

and then error out.

Full log, see: https://github.com/tianhaoz95/iwfp/pull/376/checks?check_run_id=521083728#step:9:13

Were you able to successfully deploy your functions?

I was able to deploy, but with upgrading to 3.4.0, probably not as it doesn't build.

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[mbleigh]

As a workaround, can you try deleting your package-lock.json and running npm install? We likely need to update our type dependency slightly but that may work until we can get a patch out.

[dobromyslov]

@mbleigh Thank you for the workaround.

[jacobg]

I had to delete node-modules in addition to package-lock.json to resolve this issue.

[hostankit]

It works, try deleting package-lock.json, then run npm install

[KiranVarma-gep]

I deleted node-modules as well as package-lock.json but still throwing the same error.