Update peer deps for firebase-admin v12

[atsjo]

Related issues

[REQUIRED] Version info

node:

v20.10.0

firebase-functions:

4.5.0

firebase-tools:

13.0.0

firebase-admin:

12.0.0

[REQUIRED] Test case

[REQUIRED] Steps to reproduce

update firebase-admin to v12

[REQUIRED] Expected behavior

no warning about peer deps for firebase-admin

[REQUIRED] Actual behavior

 WARN  Issues with peer dependencies found
.
└─┬ firebase-functions 4.5.0
└── ✕ unmet peer firebase-admin@"^10.0.0 || ^11.0.0": found 12.0.0

Were you able to successfully deploy your functions?

not tried, but probably yes....

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

[bitworxuk]

Yes, related to firebase/firebase-admin-node#2374

[Blunderchips]

Is this issue related to this error?

error TS2416: Property 'child' in type 'DataSnapshot' is not assignable to the same property in base type 'DataSnapshot'.
  Type '(childPath: string) => DataSnapshot' is not assignable to type '(path: string) => DataSnapshot'.
    Call signature return types 'DataSnapshot' and 'DataSnapshot' are incompatible.
      The types of 'forEach' are incompatible between these types.
        Type '(action: (a: DataSnapshot) => boolean | void) => boolean' is not assignable to type '(action: (a: IteratedDataSnapshot) => boolean | void) => boolean'.
          Types of parameters 'action' and 'action' are incompatible.
            Types of parameters 'a' and 'a' are incompatible.
              Type 'DataSnapshot' is not assignable to type 'IteratedDataSnapshot'.
                Types of property 'key' are incompatible.
                  Type 'string | null' is not assignable to type 'string'.
                    Type 'null' is not assignable to type 'string'.

Occurs on build when trying to update to firebase-admin v12

[CodingDoug]

I ran into what I believe to be a related issue. When mixing firebase-functions 4.5.0 and firebase-admin 12.0.0, the Firestore object provided by firebase-functions Firestore triggers in QueryDocumentSnapshot isn't compatible with FieldValue.serverTimestamp() imported from firebase-admin. So you get error messages like this when using these server timestamps on operations using the provided Firestore:

Value for argument "data" is not a valid Firestore document. Couldn't serialize object of type "ServerTimestampTransform" (found in field "_u"). Firestore doesn't support JavaScript objects with custom prototypes (i.e. objects that were created via the "new" operator).

Also saw this when trying to use a DocumentSnapshot provided by firebase-functions:

Error: Value for argument "refOrQuery" must be a DocumentReference, Query, or AggregateQuery.

A workaround is to not use the Firestore objects provided by firebase-functions in QueryDocumentSnapshot, and instead init firebase-admin separately, using getFirestore() to get a Firestore instance. I am assuming the updating the firebase-admin dependency will fix this.

[gbourne1]

Related issues

[REQUIRED] Version info

node:

v20.10.0

firebase-functions:

4.5.0

firebase-tools:

13.0.0

firebase-admin:

12.0.0

[REQUIRED] Test case

[REQUIRED] Steps to reproduce

update firebase-admin to v12

[REQUIRED] Expected behavior

no warning about peer deps for firebase-admin

[REQUIRED] Actual behavior

 WARN  Issues with peer dependencies found . └─┬ firebase-functions 4.5.0 └── ✕ unmet peer firebase-admin@"^10.0.0 || ^11.0.0": found 12.0.0

Were you able to successfully deploy your functions?

not tried, but probably yes....

No you are not able to deploy the functions with this per dependency issue.

[Blunderchips]

Is this issue related to this error?

error TS2416: Property 'child' in type 'DataSnapshot' is not assignable to the same property in base type 'DataSnapshot'.
  Type '(childPath: string) => DataSnapshot' is not assignable to type '(path: string) => DataSnapshot'.
    Call signature return types 'DataSnapshot' and 'DataSnapshot' are incompatible.
      The types of 'forEach' are incompatible between these types.
        Type '(action: (a: DataSnapshot) => boolean | void) => boolean' is not assignable to type '(action: (a: IteratedDataSnapshot) => boolean | void) => boolean'.
          Types of parameters 'action' and 'action' are incompatible.
            Types of parameters 'a' and 'a' are incompatible.
              Type 'DataSnapshot' is not assignable to type 'IteratedDataSnapshot'.
                Types of property 'key' are incompatible.
                  Type 'string | null' is not assignable to type 'string'.
                    Type 'null' is not assignable to type 'string'.

Occurs on build when trying to update to firebase-admin v12

Not sure if I was clear here, we cannot deploy (fails on build)

[ksinghal]

Is there a plan to support admin v12? I want the sum and average functionality and this is a blocker

[tonprince]

Any updates when firebase-functions will support firebase-admin 12?

[chrisspiegl]

I tried as well and my deployment fails with the peer dependency error described above. I really would hope that within the same ecosystem, this would be supported straight out of the box.

Is anyone at Firebase working on this?

[AuriDeimantasDev]

AFAIK only possible workaround (which won't work in every case I guess) is to do this #1496 (comment)

Hopefully it can be fixed soon, but knowing it's a xmas season, I'd assume fix should be up mid/end of Jan. 🤞 if it could be done this year though.

[Blunderchips]

I tried as well and my deployment fails with the peer dependency error described above. I really would hope that within the same ecosystem, this would be supported straight out of the box.

Is anyone at Firebase working on this?

They seem asleep at the wheel these days. I would not hold my breath for a fix anytime soon.

[bkendall]

(I'll see if I can get the right people's attention on this soon. cc @taeold @blidd-google)