Update node versions on CI tests.

firebase · Nov 1, 2023 · 31430c9 · 31430c9
1 parent 3e7a4b7
commit 31430c9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/.github/workflows/postmerge.yaml b/.github/workflows/postmerge.yaml
@@ -34,7 +34,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
 
       - uses: google-github-actions/auth@v0
         with:

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -30,9 +30,8 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 14.x
-          - 16.x
           - 18.x
+          - 20.x
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1
@@ -51,9 +50,8 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 14.x
-          - 16.x
           - 18.x
+          - 20.x
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1

diff --git a/scripts/bin-test/run.sh b/scripts/bin-test/run.sh
@@ -12,8 +12,8 @@ for f in scripts/bin-test/sources/*; do
     fi
 done
 
-## DEBUG
-ls -la scripts/bin-test/sources/commonjs/node_modules
+# Make sure firebase-functions binary is executable
+chmod +x ./lib/bin/firebase-functions.js
 
 mocha \
   --file ./scripts/bin-test/mocha-setup.ts \