Skip to content

Add Analytics header update to iOS SDK update. #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 1, 2021
Merged

Add Analytics header update to iOS SDK update. #775

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7b3b937
Add Analytics header update to iOS SDK update.
jonsimantov Dec 1, 2021
c5751e1
Fix script
jonsimantov Dec 1, 2021
811e342
Change dependency updater to run on iOS.
jonsimantov Dec 1, 2021
7b2f93b
Remove explicit list of filenames
jonsimantov Dec 1, 2021
77b79f6
Add explanatory logs
jonsimantov Dec 1, 2021
97c6413
Add explanatory note to copied header files, and autoformat them.
jonsimantov Dec 1, 2021
6c27c9f
Use the github CocoaPod source.
jonsimantov Dec 1, 2021
307dbd8
Fix comment.
jonsimantov Dec 1, 2021
f3cb738
Fix format code call.
jonsimantov Dec 1, 2021
912fb04
Add note
jonsimantov Dec 1, 2021
a5ecb18
Quote variable.
jonsimantov Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix format code call.
  • Loading branch information
@jonsimantov
jonsimantov committed Dec 1, 2021
commit f3cb738494fc1d0280147b1365c6f2fe9cb19945
2 changes: 1 addition & 1 deletion .github/workflows/update-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
# Add a note to each file about its source.
sed -i~ 's|^/// @file|// Copied from Firebase Analytics iOS SDK '${analytics_version}'.\n\n/// @file|' "${ios_header}"
rm -f "${ios_header}~" # remove backup file that sed generated
../../scripts/gha/format_code.py --f "${ios_header}"
python ../../scripts/format_code.py --f "${ios_header}"
done
cd -
rm -rf "${podtmp}"
Expand Down