Skip to content

Change Xcode version from 12.2 to 12.4 to ensure GitHub support. #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 2, 2021
Merged

Change Xcode version from 12.2 to 12.4 to ensure GitHub support. #774

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
73f1ba6
Change Xcode version from 12.2 to 12.4 to ensure GitHub support.
jonsimantov Dec 1, 2021
598ba9d
Fix iOS workflows too.
jonsimantov Dec 1, 2021
8fbb364
Fix capitalization to look all fancy-like.
jonsimantov Dec 1, 2021
7cf60ac
Fix integration tests workflow to respect xcode_version in matrix.
jonsimantov Dec 1, 2021
66b67d6
Debug log
jonsimantov Dec 1, 2021
1989328
Fix typo
jonsimantov Dec 1, 2021
304e167
Remove extra array subscript
jonsimantov Dec 1, 2021
0477e8c
Fix yml
jonsimantov Dec 1, 2021
8eb03fe
Fix yml again
jonsimantov Dec 1, 2021
8146d93
Fix yml again again
jonsimantov Dec 1, 2021
03192ca
Move array access later in case we make it a proper matrix in the future
jonsimantov Dec 1, 2021
0371754
Add xcode setting to tvos
jonsimantov Dec 1, 2021
2bb2a09
Fix desktop test to not omit ubuntu.
jonsimantov Dec 1, 2021
5af1503
Change tvOS simulator version to 14.3, 14.0 is out of date.
jonsimantov Dec 2, 2021
8da9b3f
Also set xcode version on test machines.
jonsimantov Dec 2, 2021
8d9f01f
Revert "Also set xcode version on test machines."
jonsimantov Dec 2, 2021
7886108
Actually set the xcode version on test jobs
jonsimantov Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Also set xcode version on test machines." 
This reverts commit 8da9b3f.
  • Loading branch information
@jonsimantov
jonsimantov committed Dec 2, 2021
commit 8d9f01f915678b4dc49f3fc1a6342fe6f433e204
16 changes: 4 additions & 12 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,9 +740,7 @@ jobs:
os: ${{ fromJson(needs.check_and_prepare.outputs.matrix_os) }}
ssl_variant: ${{ fromJson(needs.check_and_prepare.outputs.matrix_ssl) }}
steps:
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
run: sudo xcode-select -s /Applications/Xcode_${{ fromJson(needs.check_and_prepare.outputs.xcode_version)[0] }}.app/Cont - uses: actions/checkout@v2
- uses: actions/checkout@v2
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download Desktop integration tests artifact
Expand Down Expand Up @@ -818,9 +816,7 @@ jobs:
build_os: ${{ fromJson(needs.check_and_prepare.outputs.matrix_os) }}
android_device: ${{ fromJson(needs.check_and_prepare.outputs.android_device) }}
steps:
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
run: sudo xcode-select -s /Applications/Xcode_${{ fromJson(needs.check_and_prepare.outputs.xcode_version)[0] }}.app/Cont - uses: actions/checkout@v2
- uses: actions/checkout@v2
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download Android integration tests artifact
Expand Down Expand Up @@ -915,9 +911,7 @@ jobs:
matrix:
ios_device: ${{ fromJson(needs.check_and_prepare.outputs.ios_device) }}
steps:
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
run: sudo xcode-select -s /Applications/Xcode_${{ fromJson(needs.check_and_prepare.outputs.xcode_version)[0] }}.app/Cont - uses: actions/checkout@v2
- uses: actions/checkout@v2
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download iOS integration tests artifact
Expand Down Expand Up @@ -1013,9 +1007,7 @@ jobs:
matrix:
tvos_device: ${{ fromJson(needs.check_and_prepare.outputs.tvos_device) }}
steps:
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
run: sudo xcode-select -s /Applications/Xcode_${{ fromJson(needs.check_and_prepare.outputs.xcode_version)[0] }}.app/Cont - uses: actions/checkout@v2
- uses: actions/checkout@v2
with:
ref: ${{needs.check_and_prepare.outputs.github_ref}}
- name: Download tvOS integration tests artifact
Expand Down