Skip to content

Remove static_cast from LruGc API, and others #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dconeybe wants to merge 9 commits into
base: wuandy/LruGC
Choose a base branch
from
Draft

Remove static_cast from LruGc API, and others #1324

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fa0e48c
Merge remote-tracking branch 'origin/main' into HEAD
dconeybe May 15, 2023
335ef35
Re-implement without static_cast
dconeybe May 15, 2023
474dcee
fix operator==
dconeybe May 15, 2023
c67e4e5
minor cleanup
dconeybe May 16, 2023
f5cdefe
fix == -> =
dconeybe May 16, 2023
bd1e619
PrintTo() and fix last bug
dconeybe May 16, 2023
704a4af
Merge remote-tracking branch 'origin/wuandy/LruGC' into LruGC
dconeybe May 16, 2023
93e70fd
format code
dconeybe May 16, 2023
515df2d
clean up a bit
dconeybe May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix == -> =
  • Loading branch information
@dconeybe
dconeybe committed May 16, 2023
commit f5cdefe5cab23775b56cc8fc07061b24b35a48a8
2 changes: 1 addition & 1 deletion firestore/src/common/settings.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void Settings::set_persistence_enabled(bool enabled) {
"api set_local_cache_settings()");
}

cache_settings_source_ == CacheSettingsSource::kOld;
cache_settings_source_ = CacheSettingsSource::kOld;
persistence_enabled_ = enabled;
}

Expand Down