Skip to content

Add support for symbols with {lambda...#1} to merge_libraries.py #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2023
Merged

Add support for symbols with {lambda...#1} to merge_libraries.py #1279

merged 3 commits into from
Apr 20, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Apr 20, 2023 •
edited
Loading

Add support for symbols like this one, which is referenced by the Firestore iOS SDK on Linux:

grpc_slice_malloc_large::{lambda(grpc_slice_refcount*)#1}::_FUN(grpc_slice_refcount*)

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

C++ packaging run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/4756815007

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov
Add support for symbols like this one, which is referenced by the Fir…
e685cea 
…estore iOS SDK on Linux:

grpc_slice_malloc_large::{lambda(grpc_slice_refcount*)#1}::_FUN(grpc_slice_refcount*)
@jonsimantov
Handle #.
d3472ff
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Apr 20, 2023
@jonsimantov jonsimantov changed the title Add support for symbols with {lambda...#1} Add support for symbols with {lambda...#1} to merge_libraries.py Apr 20, 2023
@jonsimantov jonsimantov marked this pull request as ready for review April 20, 2023 18:22
@jonsimantov jonsimantov requested a review from a-maurice April 20, 2023 18:22
@jonsimantov jonsimantov merged commit 3f64f97 into main Apr 20, 2023
@jonsimantov jonsimantov deleted the fix-packaging-lambda branch April 20, 2023 18:29
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 3f64f97
Last updated: Thu Apr 20 14:01 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 20, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 20, 2023
AlmostMatt pushed a commit that referenced this pull request Apr 21, 2023
@jonsimantov @AlmostMatt
Add support for symbols with {lambda...#1} to merge_libraries.py (#1279)
32b5d53 
* Add support for symbols like this one, which is referenced by the Firestore iOS SDK on Linux:
grpc_slice_malloc_large::{lambda(grpc_slice_refcount*)#1}::_FUN(grpc_slice_refcount*)

* Handle #.

* Add the latest {lambda...#1} case to the test.
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice