Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS support for multiple User objects #1242

Merged
merged 4 commits into from
Mar 19, 2023
Merged

Conversation

DellaBitta
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Update auth internals to support returning Future object for the new API while also support returning Future<User*> objects for the deprecated API on iOS.

Changes does not include the new Future methods.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Locally run integration test on device.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@DellaBitta DellaBitta changed the title Ddb auth 1 iOS support for multiple User objects Mar 19, 2023
@DellaBitta DellaBitta marked this pull request as ready for review March 19, 2023 19:15
@DellaBitta DellaBitta merged commit c208b23 into feature/auth_googleio_23 Mar 19, 2023
@DellaBitta DellaBitta deleted the ddb_auth_1 branch March 19, 2023 21:47
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 19, 2023
@github-actions
Copy link

github-actions bot commented Mar 19, 2023

❌  Integration test FAILED

Requested by @DellaBitta on commit c208b23
Last updated: Sun Mar 19 17:22 PDT 2023
View integration test log & download artifacts

Failures Configs
auth
(4 items)[BUILD] [ERROR] [Android] [All 3 os]
[BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
database
(4 items)[BUILD] [ERROR] [Android] [All 3 os]
[BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
firestore
(4 items)[BUILD] [ERROR] [Android] [All 3 os]
[BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
functions
(4 items)[BUILD] [ERROR] [Android] [All 3 os]
[BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
storage
(4 items)[BUILD] [ERROR] [Android] [All 3 os]
[BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 20, 2023
@@ -525,6 +548,7 @@ class User : public UserInfoInterface {

// Use the pimpl mechanism to hide data details in the cpp files.
AuthData* auth_data_;
UserInternal* user_internal_;
};

} // namespace auth

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: [3 lines down] warning: More #endif's than #if's found.

~User();

/// Returns whether this User object represents a valid user. Could be false
/// on Users contained with @ref AuthResult structures from failed Auth

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'AuthResult' for \ref command

@@ -332,6 +348,9 @@
FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED()
const;

/// @deprecated This is a deprecated method. Please use
/// @ref LinkAndRetrieveDataWithCredential(const Credential&) instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'LinkAndRetrieveDataWithCredential(const Credential&)' for \ref command

@@ -332,6 +348,9 @@
FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: [10 lines up] warning: unable to resolve reference to 'LinkWithCredential(const Credential&)' for \ref command

@@ -332,6 +348,9 @@
FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: [8 lines up] warning: unable to resolve reference to 'ReauthenticateAndRetrieveData' for \ref command

Future<SignInResult> LinkAndRetrieveDataWithCredentialLastResult() const;
/// @ref LinkAndRetrieveDataWithCredential_DEPRECATED.
FIREBASE_DEPRECATED Future<SignInResult>
LinkAndRetrieveDataWithCredentialLastResult_DEPRECATED() const;

/// @deprecated This is a deprecated method. Please use
/// @ref LinkWithProvider(FederatedAuthProvider*) instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'LinkWithProvider(FederatedAuthProvider*)' for \ref command

@@ -363,20 +385,20 @@
/// @note: This operation is supported only on iOS, tvOS and Android
/// platforms. On other platforms this method will return a Future with a
/// preset error code: kAuthErrorUnimplemented.
Future<SignInResult> LinkWithProvider_DEPRECATED(
FIREBASE_DEPRECATED Future<SignInResult> LinkWithProvider_DEPRECATED(
FederatedAuthProvider* provider) const;

/// @deprecated This is a deprecated method. Please use @ref Unlink(const

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command

FederatedAuthProvider* provider) const;

/// @deprecated This is a deprecated method. Please use @ref Unlink(const
/// char*) instead.
///
/// Unlinks the current user from the provider specified.
/// Status will be an error if the user is not linked to the given provider.
Future<User*> Unlink_DEPRECATED(const char* provider);
FIREBASE_DEPRECATED Future<User*> Unlink_DEPRECATED(const char* provider);

/// @deprecated
///
/// Get results of the most recent call to @ref Unlink.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command


/// @deprecated
///
/// Get results of the most recent call to @ref Unlink.
Future<User*> UnlinkLastResult_DEPRECATED() const;
FIREBASE_DEPRECATED Future<User*> UnlinkLastResult_DEPRECATED() const;

/// @deprecated This is a deprecated method. Please use
/// @ref UpdatePhoneNumberCredential(const PhoneAuthCredential&) instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'UpdatePhoneNumberCredential(const PhoneAuthCredential&)' for \ref command

@firebase firebase locked and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant