-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS support for multiple User objects #1242
Conversation
❌ Integration test FAILEDRequested by @DellaBitta on commit c208b23
Add flaky tests to go/fpl-cpp-flake-tracker |
@@ -525,6 +548,7 @@ class User : public UserInfoInterface { | |||
|
|||
// Use the pimpl mechanism to hide data details in the cpp files. | |||
AuthData* auth_data_; | |||
UserInternal* user_internal_; | |||
}; | |||
|
|||
} // namespace auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: [3 lines down] warning: More #endif's than #if's found.
~User(); | ||
|
||
/// Returns whether this User object represents a valid user. Could be false | ||
/// on Users contained with @ref AuthResult structures from failed Auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'AuthResult' for \ref command
@@ -332,6 +348,9 @@ | |||
FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED() | |||
const; | |||
|
|||
/// @deprecated This is a deprecated method. Please use | |||
/// @ref LinkAndRetrieveDataWithCredential(const Credential&) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'LinkAndRetrieveDataWithCredential(const Credential&)' for \ref command
@@ -332,6 +348,9 @@ | |||
FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: [10 lines up] warning: unable to resolve reference to 'LinkWithCredential(const Credential&)' for \ref command
@@ -332,6 +348,9 @@ | |||
FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: [8 lines up] warning: unable to resolve reference to 'ReauthenticateAndRetrieveData' for \ref command
Future<SignInResult> LinkAndRetrieveDataWithCredentialLastResult() const; | ||
/// @ref LinkAndRetrieveDataWithCredential_DEPRECATED. | ||
FIREBASE_DEPRECATED Future<SignInResult> | ||
LinkAndRetrieveDataWithCredentialLastResult_DEPRECATED() const; | ||
|
||
/// @deprecated This is a deprecated method. Please use | ||
/// @ref LinkWithProvider(FederatedAuthProvider*) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'LinkWithProvider(FederatedAuthProvider*)' for \ref command
@@ -363,20 +385,20 @@ | |||
/// @note: This operation is supported only on iOS, tvOS and Android | |||
/// platforms. On other platforms this method will return a Future with a | |||
/// preset error code: kAuthErrorUnimplemented. | |||
Future<SignInResult> LinkWithProvider_DEPRECATED( | |||
FIREBASE_DEPRECATED Future<SignInResult> LinkWithProvider_DEPRECATED( | |||
FederatedAuthProvider* provider) const; | |||
|
|||
/// @deprecated This is a deprecated method. Please use @ref Unlink(const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
FederatedAuthProvider* provider) const; | ||
|
||
/// @deprecated This is a deprecated method. Please use @ref Unlink(const | ||
/// char*) instead. | ||
/// | ||
/// Unlinks the current user from the provider specified. | ||
/// Status will be an error if the user is not linked to the given provider. | ||
Future<User*> Unlink_DEPRECATED(const char* provider); | ||
FIREBASE_DEPRECATED Future<User*> Unlink_DEPRECATED(const char* provider); | ||
|
||
/// @deprecated | ||
/// | ||
/// Get results of the most recent call to @ref Unlink. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
|
||
/// @deprecated | ||
/// | ||
/// Get results of the most recent call to @ref Unlink. | ||
Future<User*> UnlinkLastResult_DEPRECATED() const; | ||
FIREBASE_DEPRECATED Future<User*> UnlinkLastResult_DEPRECATED() const; | ||
|
||
/// @deprecated This is a deprecated method. Please use | ||
/// @ref UpdatePhoneNumberCredential(const PhoneAuthCredential&) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'UpdatePhoneNumberCredential(const PhoneAuthCredential&)' for \ref command
Description
Update auth internals to support returning Future object for the new API while also support returning Future<User*> objects for the deprecated API on iOS.
Changes does not include the new Future methods.
Testing
Locally run integration test on device.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.