Skip to content

Remove obsolete Firestore validation tests #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented Feb 24, 2023

Description

Firestore implementation has been updated such that the validation no longer rejects use of multiple array-contains filters.
https://github.com/firebase/firebase-ios-sdk/pull/10449/files#diff-e11c1c8fc02726cb87283757008e935497911ea74a41f0efa93c4d2d6517d050

So this PR removes a test that expected this to throw an exception.
Example of a failure of the test before this change:
https://github.com/firebase/firebase-cpp-sdk/actions/runs/4242014548/jobs/7373657438


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AlmostMatt AlmostMatt added the tests-requested: quick Trigger a quick set of integration tests. label Feb 24, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 24, 2023
@github-actions
Copy link

github-actions bot commented Feb 24, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @AlmostMatt on commit d2776f0
Last updated: Fri Feb 24 15:36 PST 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 24, 2023
@AlmostMatt AlmostMatt added the skip-release-notes Skip release notes check label Feb 24, 2023
@jonsimantov jonsimantov self-requested a review February 24, 2023 21:19
@AlmostMatt AlmostMatt merged commit d2776f0 into main Feb 24, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 24, 2023
@firebase firebase locked and limited conversation to collaborators Mar 27, 2023
@AlmostMatt AlmostMatt deleted the amatt-firestore-validation branch May 19, 2023 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants