Skip to content

semaphore.h: handle spurious wakeups in TimedWait() on Linux #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2022
Merged

semaphore.h: handle spurious wakeups in TimedWait() on Linux #1021

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
869c9f9
semaphore.h: handle spurious wakeups in TimedWait() on Linux
dconeybe Jul 9, 2022
59884b2
semaphore.h: fix typo
dconeybe Jul 9, 2022
37c9f6e
semaphore.h: return false after assert in case assertions are disabled
dconeybe Jul 11, 2022
bc697b5
Add release notes entry
dconeybe Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
semaphore.h: return false after assert in case assertions are disabled
  • Loading branch information
@dconeybe
dconeybe committed Jul 11, 2022
commit 37c9f6ed05d780a263a3606e4c9af6567fe71d61
3 changes: 3 additions & 0 deletions app/src/semaphore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,13 @@ class Semaphore {
return false;
case EINVAL:
assert("sem_timedwait() failed with EINVAL" == 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure, you want this to NOT actually assert in release builds, yes? (the default assert behavior?)

return false;
case EDEADLK:
assert("sem_timedwait() failed with EDEADLK" == 0);
return false;
default:
assert("sem_timedwait() failed with an unknown error" == 0);
return false;
}
}
#endif
Expand Down