Skip to content

[Perf] Add consumer ProGuard rules for protobuf-javalite - #8697

Merged
rlazo merged 1 commit into
mainfrom
rl.perf.proguard
Oct 13, 2026
Merged

rlazo merged 1 commit into
mainfrom
rl.perf.proguard

Conversation

@rlazo

@rlazo rlazo commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Added a proguard-rules.pro file with rules to keep class members for classes extending com.google.protobuf.GeneratedMessageLite to work around a known issue in protobuf-javalite. Configured firebase-perf.gradle to include these consumer ProGuard files.

Added a `proguard-rules.pro` file with rules to keep class members for
classes extending `com.google.protobuf.GeneratedMessageLite` to work
around a known issue in protobuf-javalite. Configured
`firebase-perf.gradle` to include these consumer ProGuard files.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@rlazo
rlazo marked this pull request as ready for review October 13, 2026 17:03
@rlazo
rlazo requested a review from mrober October 13, 2026 17:04
@google-oss-bot

Copy link
Copy Markdown
Collaborator

Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR or 'NO_RELEASE_CHANGE' to the description to silence this warning.)

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo
rlazo merged commit f1f34fc into main Oct 13, 2026
37 checks passed
@rlazo
rlazo deleted the rl.perf.proguard branch October 13, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants