Skip to content

[FCM-DB] Update changelog to align with FCM #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

[FCM-DB] Update changelog to align with FCM #7050

merged 1 commit into from
Jun 19, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 19, 2025

There are no planned changes for FCM-DirectBoot to go with the planned changes for FCM. Add changelog note about it.

There are no planned changes for FCM-DirectBoot to go with the planned changes for FCM. Add changelog note about it.
@rlazo rlazo requested a review from VinayGuthal June 19, 2025 18:52
Copy link
Contributor

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.1

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rlazo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the changelog for the firebase-messaging-directboot module. The primary intent is to document that, while there are no new functional changes specific to this module, its version is being aligned with the broader Firebase Cloud Messaging (FCM) SDK. This ensures transparency and consistency across related components.

Highlights

  • Changelog Update: Added a new entry to the firebase-messaging-directboot/CHANGELOG.md file under the Unreleased section. This entry explicitly states that the module remains unchanged but its version is being updated to align with the main Firebase Cloud Messaging (FCM) SDK.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md for the firebase-messaging-directboot module. The added entry in the "Unreleased" section clarifies that the module's version is being updated to maintain alignment with the main Firebase Cloud Messaging SDK, without introducing any new functional changes to the direct boot module itself. The change is clear, consistent with existing changelog entries, and accurately reflects the PR's description. No issues of medium or higher severity were found.

@rlazo rlazo enabled auto-merge (squash) June 19, 2025 18:53
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (25e4bd9) and merge commit (1f01383).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DaLIsVNjlP.html

Copy link
Contributor

Test Results

0 files   -  24  0 suites   - 24   0s ⏱️ -35s
0 tests  - 102  0 ✅  - 102  0 💤 ±0  0 ❌ ±0 
0 runs   - 204  0 ✅  - 204  0 💤 ±0  0 ❌ ±0 

Results for commit cc6a883. ± Comparison against base commit 25e4bd9.

@rlazo rlazo merged commit cbb470a into main Jun 19, 2025
32 checks passed
@rlazo rlazo deleted the rl.fcmd.changelog branch June 19, 2025 19:00
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fcm

    DeviceStatisticsDistributions
    oriole-32
    Percentile25e4bd91f01383DiffSignificant (?)
    p101.39 ±1 ms1.35 ±0.9 ms-37.5 μs (-2.7%)NO
    p251.46 ±1 ms1.46 ±1 ms+3.46 μs (+0.2%)NO
    p501.60 ±1 ms1.63 ±1 ms+30.0 μs (+1.9%)NO
    p751.84 ±2 ms1.90 ±1 ms+65.2 μs (+3.5%)NO
    p902.08 ±2 ms2.46 ±1 ms+374 μs (+17.9%)NO

    20 test runs in comparison
    CommitTest Runs
    25e4bd9
    • 2025-06-19_18:27:27.265383_VIKL
    • 2025-06-19_18:27:27.265417_sdTd
    • 2025-06-19_18:27:27.265426_VwpI
    • 2025-06-19_18:27:27.265435_ufxB
    • 2025-06-19_18:27:27.265444_AQRE
    • 2025-06-19_18:27:27.265451_ZwAC
    • 2025-06-19_18:27:27.265458_PDLw
    • 2025-06-19_18:27:27.265465_pNuI
    • 2025-06-19_18:27:27.265471_dLMo
    • 2025-06-19_18:27:27.265479_xLag
    1f01383
    • 2025-06-19_19:10:30.267420_iQlf
    • 2025-06-19_19:10:30.267460_KCio
    • 2025-06-19_19:10:30.267472_SWhK
    • 2025-06-19_19:10:30.267481_obir
    • 2025-06-19_19:10:30.267488_mRnU
    • 2025-06-19_19:10:30.267495_bkiX
    • 2025-06-19_19:10:30.267502_HmHj
    • 2025-06-19_19:10:30.267508_Ceor
    • 2025-06-19_19:10:30.267514_hcoj
    • 2025-06-19_19:10:30.267521_AFCb
    redfin-30
    Percentile25e4bd91f01383DiffSignificant (?)
    p10820 ±309 μs934 ±363 μs+113 μs (+13.8%)NO
    p25881 ±312 μs1.05 ±0.4 ms+165 μs (+18.7%)NO
    p50973 ±329 μs1.27 ±0.6 ms+302 μs (+31.0%)NO
    p751.16 ±0.4 ms1.64 ±1 ms+485 μs (+41.9%)NO
    p901.60 ±0.6 ms2.38 ±1 ms+785 μs (+49.1%)NO

    20 test runs in comparison
    CommitTest Runs
    25e4bd9
    • 2025-06-19_18:27:27.265383_VIKL
    • 2025-06-19_18:27:27.265417_sdTd
    • 2025-06-19_18:27:27.265426_VwpI
    • 2025-06-19_18:27:27.265435_ufxB
    • 2025-06-19_18:27:27.265444_AQRE
    • 2025-06-19_18:27:27.265451_ZwAC
    • 2025-06-19_18:27:27.265458_PDLw
    • 2025-06-19_18:27:27.265465_pNuI
    • 2025-06-19_18:27:27.265471_dLMo
    • 2025-06-19_18:27:27.265479_xLag
    1f01383
    • 2025-06-19_19:10:30.267420_iQlf
    • 2025-06-19_19:10:30.267460_KCio
    • 2025-06-19_19:10:30.267472_SWhK
    • 2025-06-19_19:10:30.267481_obir
    • 2025-06-19_19:10:30.267488_mRnU
    • 2025-06-19_19:10:30.267495_bkiX
    • 2025-06-19_19:10:30.267502_HmHj
    • 2025-06-19_19:10:30.267508_Ceor
    • 2025-06-19_19:10:30.267514_hcoj
    • 2025-06-19_19:10:30.267521_AFCb
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile25e4bd91f01383DiffSignificant (?)
    p10198 ±3 ms200 ±3 ms+1.66 ms (+0.8%)NO
    p25204 ±4 ms205 ±3 ms+1.60 ms (+0.8%)NO
    p50210 ±4 ms213 ±3 ms+3.16 ms (+1.5%)NO
    p75217 ±4 ms221 ±4 ms+3.69 ms (+1.7%)NO
    p90224 ±4 ms229 ±4 ms+5.38 ms (+2.4%)NO

    20 test runs in comparison
    CommitTest Runs
    25e4bd9
    • 2025-06-19_18:27:27.265383_VIKL
    • 2025-06-19_18:27:27.265417_sdTd
    • 2025-06-19_18:27:27.265426_VwpI
    • 2025-06-19_18:27:27.265435_ufxB
    • 2025-06-19_18:27:27.265444_AQRE
    • 2025-06-19_18:27:27.265451_ZwAC
    • 2025-06-19_18:27:27.265458_PDLw
    • 2025-06-19_18:27:27.265465_pNuI
    • 2025-06-19_18:27:27.265471_dLMo
    • 2025-06-19_18:27:27.265479_xLag
    1f01383
    • 2025-06-19_19:10:30.267420_iQlf
    • 2025-06-19_19:10:30.267460_KCio
    • 2025-06-19_19:10:30.267472_SWhK
    • 2025-06-19_19:10:30.267481_obir
    • 2025-06-19_19:10:30.267488_mRnU
    • 2025-06-19_19:10:30.267495_bkiX
    • 2025-06-19_19:10:30.267502_HmHj
    • 2025-06-19_19:10:30.267508_Ceor
    • 2025-06-19_19:10:30.267514_hcoj
    • 2025-06-19_19:10:30.267521_AFCb
    redfin-30
    Percentile25e4bd91f01383DiffSignificant (?)
    p10222 ±4 ms249 ±4 ms+26.6 ms (+12.0%)YES
    p25228 ±4 ms254 ±3 ms+26.2 ms (+11.5%)YES
    p50236 ±4 ms262 ±4 ms+26.0 ms (+11.0%)YES
    p75244 ±5 ms272 ±5 ms+28.0 ms (+11.5%)YES
    p90253 ±7 ms287 ±8 ms+33.7 ms (+13.3%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    25e4bd9
    • 2025-06-19_18:27:27.265383_VIKL
    • 2025-06-19_18:27:27.265417_sdTd
    • 2025-06-19_18:27:27.265426_VwpI
    • 2025-06-19_18:27:27.265435_ufxB
    • 2025-06-19_18:27:27.265444_AQRE
    • 2025-06-19_18:27:27.265451_ZwAC
    • 2025-06-19_18:27:27.265458_PDLw
    • 2025-06-19_18:27:27.265465_pNuI
    • 2025-06-19_18:27:27.265471_dLMo
    • 2025-06-19_18:27:27.265479_xLag
    1f01383
    • 2025-06-19_19:10:30.267420_iQlf
    • 2025-06-19_19:10:30.267460_KCio
    • 2025-06-19_19:10:30.267472_SWhK
    • 2025-06-19_19:10:30.267481_obir
    • 2025-06-19_19:10:30.267488_mRnU
    • 2025-06-19_19:10:30.267495_bkiX
    • 2025-06-19_19:10:30.267502_HmHj
    • 2025-06-19_19:10:30.267508_Ceor
    • 2025-06-19_19:10:30.267514_hcoj
    • 2025-06-19_19:10:30.267521_AFCb

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hmeCXWKBdy/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants