Fix cold starts incorrectly using the previous firstSessionId #7047
Conversation
Firebase AI Mock Responses Check
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mrober, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug where cold starts were not consistently creating new sessions, leading to incorrect session tracking by reusing firstSessionId and sessionIndex from previous sessions. The changes ensure that every cold start correctly initiates a brand new session, improving the accuracy and reliability of session data.
Highlights
- Session Generation Logic: The core logic for generating new sessions in
SharedSessionRepository.kthas been updated. Previously, during a cold start, the system might incorrectly reuse thefirstSessionIdandsessionIndexfrom a prior session if it hadn't technically expired. This change ensures that when a cold start is detected, a completely new session is always generated by explicitly passingnullas the previous session details to thesessionGenerator.generateNewSessionmethod. - Test Case Alignment: A test case in
SharedSessionRepositoryTest.ktwas modified to reflect the correct expectedfirstSessionIdandsessionIndexfor a newly generated session after a cold start. This confirms that the fix behaves as intended, with the new session correctly starting with its own ID asfirstSessionIdand asessionIndexof 0. - Minor Code Cleanup: A
TODOcomment related to session time validation was removed fromSharedSessionRepository.kt.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Generated by 🚫 Danger |
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the issue of cold starts improperly reusing firstSessionId and sessionIndex. The logic changes in SharedSessionRepository.kt ensure that a new session with a reset firstSessionId and sessionIndex is created during a cold start. The test updates in SharedSessionRepositoryTest.kt align with this corrected behavior. The main actionable feedback is to remove a debugging println statement.
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SharedSessionRepository.kt
Outdated
Show resolved
Hide resolved
Coverage Report 1Affected Products
Test Logs |
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SharedSessionRepository.kt
Show resolved
Hide resolved
Fix cold starts incorrectly using the previous firstSessionId and sessionIndex This came up during the dogfooding session When a cold start happens, we must always create a new session. Before this fix, it would preserve the current session's firstSesisonId and sessionIndex when that session hadn't expired. But a cold start is regardless of the current session expiring
Fix cold starts incorrectly using the previous firstSessionId and sessionIndex
This came up during the dogfooding session
When a cold start happens, we must always create a new session. Before this fix, it would preserve the current session's firstSesisonId and sessionIndex when that session hadn't expired. But a cold start is regardless of the current session expiring