Conversation
… 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.5.0, 2.6.0, 2.6.1, and 2.6.2
Adding `@check` to a field with side effects became illegal since cl/756896487. The fix in this commit adds a "query" field (which has no side effects) and, instead, attaches the `@check` directive to that. This fixes the following 2 test failures in `OperationExecutionErrorsIntegrationTest`: * `executeMutationFailsWithNonNullDataNonEmptyErrorsDecodingSucceeds` * `executeMutationFailsWithNonNullDataNonEmptyErrorsDecodingFails` The test failures looked like this: ``` io.kotest.assertions.MultiAssertionError: The following 2 assertions failed: 1) exception.message "operation encountered errors during execution: [mutation.createPersonWithPartialFailure.person2: @check is disallowed on side-effect fields unless the operation has @transaction]" should contain the substring "ecxpjy4qfy" with non-abutting text at com.google.firebase.dataconnect.testutil.TestUtilsKt.shouldContainWithNonAbuttingText(TestUtils.kt:79) 2) exception.response.rawData Expected [("person1", [("id", "com.google.firebase.dataconnect.OperationExecutionErrorsIntegrationTest.executeMutationFailsWithNonNullDataNonEmptyErrorsDecodingFails_vNGzY61U2l3DkpBiK4s1")]), ("person2", <null>)] but actual was null at com.google.firebase.dataconnect.testutil.DataConnectOperationExceptionTestUtilsKt.shouldSatisfy(DataConnectOperationExceptionTestUtils.kt:74) at com.google.firebase.dataconnect.testutil.DataConnectOperationExceptionTestUtilsKt.shouldSatisfy(DataConnectOperationExceptionTestUtils.kt:266) at com.google.firebase.dataconnect.OperationExecutionErrorsIntegrationTest$executeMutationFailsWithNonNullDataNonEmptyErrorsDecodingFails$1.invokeSuspend(OperationExecutionErrorsIntegrationTest.kt:224) ```
…ansaction: `executeMutationFailsWithNonNullDataNonEmptyErrorsDecodingFailsInTransaction`
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
aashishpatil-g
approved these changes
May 30, 2025
Contributor
Collaborator
Size Report 1Affected ProductsNo changes between base commit (b2fe881) and merge commit (f189871).Test Logs |
Collaborator
Coverage Report 1Affected Products
Test Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataConnectExecutableVersions.json updated with versions 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.5.0, 2.6.0, 2.6.1, and 2.6.2 by running:
As part of this upgrade, 2 test failures needed to be fixed because the
@checkdirective on a field with side effects became illegal since cl/756896487. The fix in this PR adds a "query" field (which has no side effects) and, instead, attaches the@checkdirective to that.This fixes the following 2 test failures in
OperationExecutionErrorsIntegrationTest:executeMutationFailsWithNonNullDataNonEmptyErrorsDecodingSucceedsexecuteMutationFailsWithNonNullDataNonEmptyErrorsDecodingFailsThe test failures looked like this: