Skip to content

Fix the profile case with clear app data #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

mrober
Copy link
Contributor

@mrober mrober commented May 29, 2025

Fix the profile case with clear app data. Now the app data will clear in the setup block, instead of the measure block. This also reads the output to make sure app data has cleared before proceeding to the measure block.

@mrober mrober requested a review from tejasd May 29, 2025 20:29
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (75f0919) and merge commit (8dd87f9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kXRam4GCkn.html

Copy link
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c282661.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (75f0919) and merge commit (8dd87f9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dTSeYBFwEP.html

@mrober mrober merged commit 7b0cbe7 into sessions-sharedrepo May 30, 2025
24 of 26 checks passed
@mrober mrober deleted the mrober/clearAppData2 branch May 30, 2025 13:58
mrober added a commit that referenced this pull request May 30, 2025
Fix the profile case with clear app data. Now the app data will clear in
the setup block, instead of the measure block. This also reads the
output to make sure app data has cleared before proceeding to the
measure block.
mrober added a commit that referenced this pull request Jun 2, 2025
Fix the profile case with clear app data. Now the app data will clear in
the setup block, instead of the measure block. This also reads the
output to make sure app data has cleared before proceeding to the
measure block.
mrober added a commit that referenced this pull request Jun 5, 2025
Fix the profile case with clear app data. Now the app data will clear in
the setup block, instead of the measure block. This also reads the
output to make sure app data has cleared before proceeding to the
measure block.
mrober added a commit that referenced this pull request Jun 17, 2025
Fix the profile case with clear app data. Now the app data will clear in
the setup block, instead of the measure block. This also reads the
output to make sure app data has cleared before proceeding to the
measure block.
mrober added a commit that referenced this pull request Jun 20, 2025
Fix the profile case with clear app data. Now the app data will clear in
the setup block, instead of the measure block. This also reads the
output to make sure app data has cleared before proceeding to the
measure block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants