Skip to content

background time nullable #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

background time nullable #6886

merged 1 commit into from
Apr 16, 2025

Conversation

themiswang
Copy link
Contributor

Make background time nullable
For each new session generated, reset background time
Update unit tests

@themiswang themiswang requested a review from mrober April 16, 2025 17:51
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 16, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (46f521f) to 82.99% (c926028) by ?.

    45 individual files with coverage change

    FilenameBase (46f521f)Merge (c926028)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.12%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?62.50%?
    FirebaseSessionsComponent.kt?65.79%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?58.82%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?83.33%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?22.22%?
    SessionsActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?81.40%?
    SharedSessionRepositoryImpl_Factory.java?0.00%?
    TimeProvider.kt?75.00%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bvxqcViHsP.html

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 36 files   36 suites   43s ⏱️
 78 tests  78 ✅ 0 💤 0 ❌
156 runs  156 ✅ 0 💤 0 ❌

Results for commit e04d997.

mrober
mrober approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@mrober mrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits, LGTM

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 16, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (46f521f)Merge (c926028)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (46f521f)Merge (c926028)Diff
    aar?202 kB? (?)
    apk (aggressive)?533 kB? (?)
    apk (release)?5.78 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JZ7BmRoeLk.html

@themiswang themiswang force-pushed the backgroundTimeNullable branch from e04d997 to 676973b Compare April 16, 2025 18:17
@themiswang themiswang merged commit d14ecab into sessions-sharedrepo Apr 16, 2025
28 of 29 checks passed
@themiswang themiswang deleted the backgroundTimeNullable branch April 16, 2025 18:19
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
background time nullable (#6886)
d4eb55c 
Make background time nullable
For each new session generated, reset background time
Update unit tests
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
background time nullable (#6886)
a81cc37 
Make background time nullable
For each new session generated, reset background time
Update unit tests
mrober pushed a commit that referenced this pull request May 12, 2025
@themiswang @mrober
background time nullable (#6886)
ef8e3c4 
Make background time nullable
For each new session generated, reset background time
Update unit tests
@firebase firebase locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themiswang @google-oss-bot @mrober