Skip to content

Add unit tests for session repo #6878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Add unit tests for session repo #6878

merged 1 commit into from
Apr 15, 2025

Conversation

themiswang
Copy link
Contributor

No description provided.

@themiswang themiswang requested a review from mrober April 15, 2025 18:33
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (ad11092) to 81.95% (fa19083) by ?.

    45 individual files with coverage change

    FilenameBase (ad11092)Merge (fa19083)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.12%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?62.50%?
    FirebaseSessionsComponent.kt?65.79%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?58.82%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?83.33%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?22.22%?
    SessionsActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?71.08%?
    SharedSessionRepositoryImpl_Factory.java?0.00%?
    TimeProvider.kt?75.00%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/enKiG96iN3.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

Test Results

 36 files   36 suites   46s ⏱️
 78 tests  78 ✅ 0 💤 0 ❌
156 runs  156 ✅ 0 💤 0 ❌

Results for commit 8063dbf.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (ad11092)Merge (fa19083)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (ad11092)Merge (fa19083)Diff
    aar?202 kB? (?)
    apk (aggressive)?533 kB? (?)
    apk (release)?5.78 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cpfwfB31SB.html

@themiswang themiswang changed the title Add unit tests for session Repo Add unit tests for session repo Apr 15, 2025
@themiswang themiswang requested a review from tejasd April 15, 2025 18:53
@themiswang themiswang force-pushed the sessionRepoUnitTest branch from 046f833 to 1eb5919 Compare April 15, 2025 19:19
@themiswang themiswang force-pushed the sessionRepoUnitTest branch from 1eb5919 to 8063dbf Compare April 15, 2025 20:12
@themiswang themiswang merged commit 46f521f into sessions-sharedrepo Apr 15, 2025
31 of 32 checks passed
@themiswang themiswang deleted the sessionRepoUnitTest branch April 15, 2025 20:31
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
Add unit tests for session repo (#6878)
9fd3184
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
Add unit tests for session repo (#6878)
572e500
mrober pushed a commit that referenced this pull request May 12, 2025
@themiswang @mrober
Add unit tests for session repo (#6878)
0fb8f90
@firebase firebase locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

@tejasd tejasd Awaiting requested review from tejasd

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themiswang @google-oss-bot @mrober