Skip to content

Fallback try catch block #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fallback try catch block #6873

merged 1 commit into from
Apr 15, 2025

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Apr 15, 2025 •
edited
Loading

Using try catch block to make datastore fall back to a pre multi-process supported version. Generate a new session locally then notify to subscribers

@themiswang themiswang requested a review from mrober April 15, 2025 13:53
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (0377041) to 77.51% (95a3a9a) by ?.

    45 individual files with coverage change

    FilenameBase (0377041)Merge (95a3a9a)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.12%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?62.50%?
    FirebaseSessionsComponent.kt?65.79%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?58.82%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?78.57%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?22.22%?
    SessionsActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?29.63%?
    SharedSessionRepositoryImpl_Factory.java?0.00%?
    TimeProvider.kt?62.50%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hru9IzbWFD.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

Test Results

 34 files   34 suites   42s ⏱️
 74 tests  74 ✅ 0 💤 0 ❌
148 runs  148 ✅ 0 💤 0 ❌

Results for commit d53cf98.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (0377041)Merge (95a3a9a)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (0377041)Merge (95a3a9a)Diff
    aar?202 kB? (?)
    apk (aggressive)?533 kB? (?)
    apk (release)?5.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b4Fvqy0pHK.html

@themiswang themiswang force-pushed the fallbackModeV3 branch 2 times, most recently from 9d2415a to 499d409 Compare April 15, 2025 14:50
@themiswang themiswang marked this pull request as ready for review April 15, 2025 14:51
@themiswang themiswang requested a review from tejasd April 15, 2025 14:51
@themiswang themiswang merged commit 502942f into sessions-sharedrepo Apr 15, 2025
30 of 32 checks passed
@themiswang themiswang deleted the fallbackModeV3 branch April 15, 2025 18:13
mrober pushed a commit that referenced this pull request Apr 15, 2025
@themiswang @mrober
Fallback try catch block (#6873)
ad11092 
Using try catch block to make datastore fall back to a pre multi-process
supported version. Generate a new session locally then notify to
subscribers
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
Fallback try catch block (#6873)
99c1333 
Using try catch block to make datastore fall back to a pre multi-process
supported version. Generate a new session locally then notify to
subscribers
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
Fallback try catch block (#6873)
7981a81 
Using try catch block to make datastore fall back to a pre multi-process
supported version. Generate a new session locally then notify to
subscribers
mrober pushed a commit that referenced this pull request May 12, 2025
@themiswang @mrober
Fallback try catch block (#6873)
9fffe12 
Using try catch block to make datastore fall back to a pre multi-process
supported version. Generate a new session locally then notify to
subscribers
@firebase firebase locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tejasd tejasd tejasd approved these changes

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themiswang @google-oss-bot @tejasd @mrober