Skip to content

Fix unit tests showing warning about datastore_shared_counter #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

Fix unit tests showing warning about datastore_shared_counter #6830

merged 2 commits into from
Apr 2, 2025

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 2, 2025

Fix Robolectric tests showing warning about datastore_shared_counter by falling back to the normal DataStore instance. This is a known issue, see b/352047731.

@mrober mrober requested a review from themiswang April 2, 2025 13:38
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (fcd270c) to 67.26% (738272f) by ?.

    46 individual files with coverage change

    FilenameBase (fcd270c)Merge (738272f)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?100.00%?
    DaggerFirebaseSessionsComponent.java?0.00%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsComponent.kt?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?0.00%?
    FirebaseSessionsDependencies.kt?92.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?0.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionDatastore.kt?78.13%?
    SessionDatastoreImpl_Factory.java?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?84.21%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?95.45%?
    SessionGenerator_Factory.java?0.00%?
    SessionLifecycleClient.kt?91.78%?
    SessionLifecycleService.kt?78.65%?
    SessionLifecycleServiceBinder.kt?0.00%?
    SessionLifecycleServiceBinderImpl_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?55.56%?
    SessionsSettings.kt?96.88%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?100.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?60.00%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zFknMHLgXu.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025 •
edited
Loading

Test Results

  146 files    146 suites   2m 46s ⏱️
1 054 tests 1 054 ✅ 0 💤 0 ❌
2 108 runs  2 108 ✅ 0 💤 0 ❌

Results for commit 28a5cf1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (fcd270c)Merge (738272f)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (fcd270c)Merge (738272f)Diff
    aar?208 kB? (?)
    apk (aggressive)?539 kB? (?)
    apk (release)?5.78 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EkKCseGoug.html

@mrober mrober merged commit 54f5602 into fireperf-aqs Apr 2, 2025
35 checks passed
@mrober mrober deleted the mrober/unittestfix branch April 2, 2025 15:32
tejasd pushed a commit that referenced this pull request Apr 3, 2025
@mrober @tejasd
Fix unit tests showing warning about datastore_shared_counter (#6830)
e0eb4c9 
Fix Robolectric tests showing warning about datastore_shared_counter by
falling back to the normal DataStore instance. This is a known issue,
see [b/352047731](http://b/352047731).
mrober added a commit that referenced this pull request Apr 7, 2025
@mrober
Fix unit tests showing warning about datastore_shared_counter (#6830)
20a4864 
Fix Robolectric tests showing warning about datastore_shared_counter by
falling back to the normal DataStore instance. This is a known issue,
see [b/352047731](http://b/352047731).
mrober added a commit that referenced this pull request Apr 15, 2025
@mrober
Fix unit tests showing warning about datastore_shared_counter (#6830)
950fecd 
Fix Robolectric tests showing warning about datastore_shared_counter by
falling back to the normal DataStore instance. This is a known issue,
see [b/352047731](http://b/352047731).
@firebase firebase locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themiswang themiswang themiswang approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @themiswang