Avoid Process.myProcessName() on Android 13#6720
Merged
Conversation
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Collaborator
Coverage Report 1Affected ProductsNo changes between base commit (ec26a52) and merge commit (b301578).Test Logs |
Contributor
Test Results 38 files - 148 38 suites - 148 59s ⏱️ - 3m 27s Results for commit b7fe42a. ± Comparison against base commit ec26a52. This pull request removes 1235 and adds 95 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Collaborator
Size Report 1Affected Products
Test Logs |
tejasd
approved these changes
Feb 25, 2025
...crashlytics/src/main/java/com/google/firebase/crashlytics/internal/ProcessDetailsProvider.kt
Show resolved
Hide resolved
tejasd
pushed a commit
that referenced
this pull request
Apr 1, 2025
Avoid calling `Process.myProcessName()` on Android 13 because it appears to be missing from some OEM-specific Android 13 builds. It is fine to just let the method fall through to the next, older, method to get the process name. See firebase/firebase-unity-sdk#1059 I have not been able to reproduce this issue locally, but this change is very safe. We should consider refactoring Crashlytics to consume the Sessions `ProcessDetails` data class, instead of the current `@AutoValue` holder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid calling
Process.myProcessName()on Android 13 because it appears to be missing from some OEM-specific Android 13 builds. It is fine to just let the method fall through to the next, older, method to get the process name. See firebase/firebase-unity-sdk#1059I have not been able to reproduce this issue locally, but this change is very safe.
We should consider refactoring Crashlytics to consume the Sessions
ProcessDetailsdata class, instead of the current@AutoValueholder.