Extend Firebase SDK with new APIs to consume streaming callable function response #6602

MustafaJadid2025 · 2024-12-16T22:03:33Z

Extend Firebase SDK with new APIs to consume streaming callable function response.

Handling the server-sent event (SSE) parsing internally
Providing proper error handling and connection management
Maintaining memory efficiency for long-running streams

…ion response. - Handling the server-sent event (SSE) parsing internally - Providing proper error handling and connection management - Maintaining memory efficiency for long-running streams

…m-functions-api # Conflicts: # firebase-functions/src/androidTest/java/com/google/firebase/functions/StramTests.kt

…ivestreams.Subscriber interface.

…ndroid-sdk-fork into stream-functions-api

…m-functions-api

rlazo · 2025-02-11T15:30:59Z

is this PR ready for review? please assign @emilypgoogle and myself as reviewers as soon as it's ready. Thanks

MustafaJadid2025

The PR is ready for review.

firebase-functions/api.txt

firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt

firebase-functions/src/main/java/com/google/firebase/functions/StreamResponse.kt

firebase-functions/src/androidTest/java/com/google/firebase/functions/StreamTests.kt

firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt

firebase-functions/src/main/java/com/google/firebase/functions/StreamResponse.kt

- Embedded the distinction between `message` and `result` in test cases.

firebase-functions/src/androidTest/backend/functions/index.js

firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt

firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt

firebase-functions/src/main/java/com/google/firebase/functions/PublisherStream.kt

firebase-functions/src/androidTest/java/com/google/firebase/functions/StreamTests.kt

firebase-functions/src/main/java/com/google/firebase/functions/PublisherStream.kt

- Update the api.txt

MustafaJadid2025 · 2025-03-04T01:48:40Z

Please, regenerate the api.txt file

Done

…Synchronize request(n), and Handle Late Subscribers.

emilypgoogle

Aside from my excessive synchronization comments which are non-blocking, all of my concerns were addressed and this seems to add the feature in line with reactive stream behavior expectations. @rlazo should make sure his concerns are also addressed

firebase-functions/src/androidTest/backend/functions/index.js

firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt

…LargeData on index.js. - Modify genStreamError.

…mLargeData.

firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt

…m-functions-api

…ion response (#6602) Extend Firebase SDK with new APIs to consume streaming callable function response. - Handling the server-sent event (SSE) parsing internally - Providing proper error handling and connection management - Maintaining memory efficiency for long-running streams --------- Co-authored-by: Rodrigo Lazo <rlazo@users.noreply.github.com>

Extend Firebase SDK with new APIs to consume streaming callable funct…

535fb90

…ion response. - Handling the server-sent event (SSE) parsing internally - Providing proper error handling and connection management - Maintaining memory efficiency for long-running streams

google-oss-bot added the size/L label Dec 16, 2024

Extend Firebase SDK with new APIs to consume streaming callable funct…

9e13ef7

…ion response. - Handling the server-sent event (SSE) parsing internally - Providing proper error handling and connection management - Maintaining memory efficiency for long-running streams

google-oss-bot added size/XL and removed size/L labels Dec 26, 2024

MustafaJadid2025 and others added 3 commits December 26, 2024 11:50

Merge remote-tracking branch 'origin/stream-functions-api' into strea…

6d3012d

…m-functions-api # Conflicts: # firebase-functions/src/androidTest/java/com/google/firebase/functions/StramTests.kt

Merge branch 'firebase:main' into stream-functions-api

a4a442c

Update the SSETaskListener implementation to conform to the org.react…

1fa85a6

…ivestreams.Subscriber interface.

mikehardy mentioned this pull request Jan 4, 2025

🐛 [@react-native-firebase/functions] Missing stream implementation for httpsCallable functions invertase/react-native-firebase#8210

Closed

MustafaJadid2025 and others added 12 commits January 22, 2025 11:34

Merge branch 'main' into stream-functions-api

21b45b0

Merge branch 'main' into stream-functions-api

5fda178

Merge branch 'main' of https://github.com/MustafaJadid2025/firebase-a…

a244078

…ndroid-sdk-fork into stream-functions-api

Merge remote-tracking branch 'origin/stream-functions-api' into strea…

05b9772

…m-functions-api

Refactor Stream Listener Implementation

7034537

Fix test cases on StreamTests.

7f0382b

Optimize streaming by introducing reactive.streams

e009960

Merge branch 'main' into stream-functions-api

8ea53bd

Fix test case testGenStreamError.

1584847

Update api.txt.

ee964a5

Remove StreamListener.kt and StreamFunctionsTask.kt

895ee02

Merge branch 'main' into stream-functions-api

e2069d4

Merge branch 'main' into stream-functions-api

0fd7894

MustafaJadid2025 commented Feb 11, 2025

View reviewed changes

Introduce StreamResponse to accommodate Stream Message and Result.

4f8f7d4

rlazo requested review from emilypgoogle and rlazo February 12, 2025 15:07

emilypgoogle requested changes Feb 12, 2025

View reviewed changes

thatfiredev reviewed Feb 12, 2025

View reviewed changes

firebase-functions/src/main/java/com/google/firebase/functions/StreamResponse.kt Outdated Show resolved Hide resolved

Refactor StreamResponse, PublisherStream.

38f3e8e

- Embedded the distinction between `message` and `result` in test cases.

rlazo reviewed Feb 28, 2025

View reviewed changes

emilypgoogle requested changes Feb 28, 2025

View reviewed changes

MustafaJadid2025 and others added 2 commits March 3, 2025 09:52

Merge branch 'main' into stream-functions-api

d839f6d

Add a test case where the client input is processed.

3f313c7

- Update the api.txt

MustafaJadid2025 added 2 commits March 3, 2025 18:00

Optimize the stream() method on HttpCallableReference.

e3c26a3

Improve Subscription Handling: Ensure onError() Terminates Properly, …

14ea9a6

…Synchronize request(n), and Handle Late Subscribers.

MustafaJadid2025 requested review from rlazo and emilypgoogle March 4, 2025 22:06

Merge branch 'main' into stream-functions-api

37eed41

emilypgoogle approved these changes Mar 5, 2025

View reviewed changes

MustafaJadid2025 and others added 3 commits March 5, 2025 11:54

Merge branch 'main' into stream-functions-api

fc2516c

Remove excessive synchronization in methods notifyError, notifyComplete.

2fa63b8

Merge branch 'main' into stream-functions-api

2f2d66d

ncooke3 reviewed Mar 5, 2025

View reviewed changes

firebase-functions/src/androidTest/backend/functions/index.js Show resolved Hide resolved

firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt Outdated Show resolved Hide resolved

MustafaJadid2025 and others added 4 commits March 5, 2025 17:04

Add firebase functions genStreamEmpty, genStreamResultOnly, genStream…

b6d9b22

…LargeData on index.js. - Modify genStreamError.

Correct the KDoc format.

5541852

Add test cases to cover genStreamEmpty, genStreamResultOnly, genStrea…

38876b5

…mLargeData.

Merge branch 'main' into stream-functions-api

b74c68c

thatfiredev reviewed Mar 10, 2025

View reviewed changes

firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt Show resolved Hide resolved

rlazo approved these changes Mar 10, 2025

View reviewed changes

MustafaJadid2025 and others added 4 commits March 10, 2025 13:05

Add annotation @jvmoverloads to stream method on HttpsCallableReference.

76567b4

Merge branch 'main' into stream-functions-api

2cf4099

Update api.txt.

005223c

Merge remote-tracking branch 'origin/stream-functions-api' into strea…

4e87b0c

…m-functions-api

emilypgoogle merged commit 7c03f49 into firebase:main Mar 10, 2025
26 of 27 checks passed

MustafaJadid2025 deleted the stream-functions-api branch March 10, 2025 20:38

victoire-hergan mentioned this pull request Mar 18, 2025

[cloud_functions] feature request for stream support firebase/flutterfire#17076

Closed

firebase locked and limited conversation to collaborators Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extend Firebase SDK with new APIs to consume streaming callable function response #6602

Extend Firebase SDK with new APIs to consume streaming callable function response #6602

Uh oh!

MustafaJadid2025 commented Dec 16, 2024

Uh oh!

rlazo commented Feb 11, 2025

Uh oh!

MustafaJadid2025 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MustafaJadid2025 commented Mar 4, 2025

Uh oh!

emilypgoogle left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Extend Firebase SDK with new APIs to consume streaming callable function response #6602

Extend Firebase SDK with new APIs to consume streaming callable function response #6602

Uh oh!

Conversation

MustafaJadid2025 commented Dec 16, 2024

Uh oh!

rlazo commented Feb 11, 2025

Uh oh!

MustafaJadid2025 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MustafaJadid2025 commented Mar 4, 2025

Uh oh!

emilypgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!