Skip to content

Fix falsely removed changelog #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix falsely removed changelog #5707

merged 1 commit into from
Feb 12, 2024

Conversation

cherylEnkidu
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@cherylEnkidu cherylEnkidu enabled auto-merge (squash) February 12, 2024 19:19
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.84% (a4ca0cb) to 44.84% (452b9ef) by -0.01%.

    FilenameBase (a4ca0cb)Merge (452b9ef)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TrrWRFlNbP.html

@cherylEnkidu cherylEnkidu merged commit 6a97c30 into master Feb 12, 2024
@cherylEnkidu cherylEnkidu deleted the cheryllin/changelog branch February 12, 2024 19:23
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentilea4ca0cb452b9efDiffSignificant (?)
    p10318 ±16 μs319 ±17 μs+111 ns (+0.0%)NO
    p25332 ±26 μs333 ±22 μs+223 ns (+0.1%)NO
    p50351 ±35 μs363 ±55 μs+12.2 μs (+3.5%)NO
    p75392 ±54 μs420 ±90 μs+28.4 μs (+7.3%)NO
    p90471 ±87 μs525 ±196 μs+53.9 μs (+11.5%)NO

    20 test runs in comparison
    CommitTest Runs
    a4ca0cb
    • 2024-02-12_16:59:16.954094_Bahn
    • 2024-02-12_16:59:16.954129_MOXl
    • 2024-02-12_16:59:16.954136_ijmI
    • 2024-02-12_16:59:16.954150_eSgn
    • 2024-02-12_16:59:16.954159_ITdp
    • 2024-02-12_16:59:16.954167_pEcP
    • 2024-02-12_16:59:16.954175_RBJe
    • 2024-02-12_16:59:16.954182_cvUP
    • 2024-02-12_16:59:16.954189_UwsF
    • 2024-02-12_16:59:16.954196_yOVn
    452b9ef
    • 2024-02-12_19:27:53.087603_ydDH
    • 2024-02-12_19:27:53.087639_uufl
    • 2024-02-12_19:27:53.087651_lxVk
    • 2024-02-12_19:27:53.087659_JIpa
    • 2024-02-12_19:27:53.087667_aTPb
    • 2024-02-12_19:27:53.087674_CJvn
    • 2024-02-12_19:27:53.087686_FZSe
    • 2024-02-12_19:27:53.087694_TmQZ
    • 2024-02-12_19:27:53.087700_jSfY
    • 2024-02-12_19:27:53.087707_ruFr
    redfin-30
    Percentilea4ca0cb452b9efDiffSignificant (?)
    p10654 ±160 μs665 ±169 μs+11.5 μs (+1.8%)NO
    p25677 ±159 μs687 ±168 μs+10.5 μs (+1.5%)NO
    p50703 ±159 μs717 ±170 μs+13.7 μs (+1.9%)NO
    p75744 ±165 μs756 ±170 μs+12.8 μs (+1.7%)NO
    p90834 ±196 μs828 ±186 μs-6.57 μs (-0.8%)NO

    20 test runs in comparison
    CommitTest Runs
    a4ca0cb
    • 2024-02-12_16:59:16.954094_Bahn
    • 2024-02-12_16:59:16.954129_MOXl
    • 2024-02-12_16:59:16.954136_ijmI
    • 2024-02-12_16:59:16.954150_eSgn
    • 2024-02-12_16:59:16.954159_ITdp
    • 2024-02-12_16:59:16.954167_pEcP
    • 2024-02-12_16:59:16.954175_RBJe
    • 2024-02-12_16:59:16.954182_cvUP
    • 2024-02-12_16:59:16.954189_UwsF
    • 2024-02-12_16:59:16.954196_yOVn
    452b9ef
    • 2024-02-12_19:27:53.087603_ydDH
    • 2024-02-12_19:27:53.087639_uufl
    • 2024-02-12_19:27:53.087651_lxVk
    • 2024-02-12_19:27:53.087659_JIpa
    • 2024-02-12_19:27:53.087667_aTPb
    • 2024-02-12_19:27:53.087674_CJvn
    • 2024-02-12_19:27:53.087686_FZSe
    • 2024-02-12_19:27:53.087694_TmQZ
    • 2024-02-12_19:27:53.087700_jSfY
    • 2024-02-12_19:27:53.087707_ruFr
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilea4ca0cb452b9efDiffSignificant (?)
    p10203 ±5 ms211 ±5 ms+7.72 ms (+3.8%)NO
    p25209 ±6 ms217 ±5 ms+7.50 ms (+3.6%)NO
    p50217 ±7 ms224 ±6 ms+7.07 ms (+3.3%)NO
    p75227 ±8 ms236 ±6 ms+9.63 ms (+4.3%)NO
    p90236 ±8 ms255 ±9 ms+19.4 ms (+8.2%)NO

    20 test runs in comparison
    CommitTest Runs
    a4ca0cb
    • 2024-02-12_16:59:16.954094_Bahn
    • 2024-02-12_16:59:16.954129_MOXl
    • 2024-02-12_16:59:16.954136_ijmI
    • 2024-02-12_16:59:16.954150_eSgn
    • 2024-02-12_16:59:16.954159_ITdp
    • 2024-02-12_16:59:16.954167_pEcP
    • 2024-02-12_16:59:16.954175_RBJe
    • 2024-02-12_16:59:16.954182_cvUP
    • 2024-02-12_16:59:16.954189_UwsF
    • 2024-02-12_16:59:16.954196_yOVn
    452b9ef
    • 2024-02-12_19:27:53.087603_ydDH
    • 2024-02-12_19:27:53.087639_uufl
    • 2024-02-12_19:27:53.087651_lxVk
    • 2024-02-12_19:27:53.087659_JIpa
    • 2024-02-12_19:27:53.087667_aTPb
    • 2024-02-12_19:27:53.087674_CJvn
    • 2024-02-12_19:27:53.087686_FZSe
    • 2024-02-12_19:27:53.087694_TmQZ
    • 2024-02-12_19:27:53.087700_jSfY
    • 2024-02-12_19:27:53.087707_ruFr
    redfin-30
    Percentilea4ca0cb452b9efDiffSignificant (?)
    p10250 ±3 ms272 ±7 ms+22.0 ms (+8.8%)MAYBE
    p25256 ±3 ms278 ±7 ms+22.3 ms (+8.7%)MAYBE
    p50264 ±4 ms287 ±5 ms+23.0 ms (+8.7%)MAYBE
    p75275 ±4 ms297 ±6 ms+22.8 ms (+8.3%)MAYBE
    p90287 ±6 ms317 ±9 ms+29.7 ms (+10.4%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    a4ca0cb
    • 2024-02-12_16:59:16.954094_Bahn
    • 2024-02-12_16:59:16.954129_MOXl
    • 2024-02-12_16:59:16.954136_ijmI
    • 2024-02-12_16:59:16.954150_eSgn
    • 2024-02-12_16:59:16.954159_ITdp
    • 2024-02-12_16:59:16.954167_pEcP
    • 2024-02-12_16:59:16.954175_RBJe
    • 2024-02-12_16:59:16.954182_cvUP
    • 2024-02-12_16:59:16.954189_UwsF
    • 2024-02-12_16:59:16.954196_yOVn
    452b9ef
    • 2024-02-12_19:27:53.087603_ydDH
    • 2024-02-12_19:27:53.087639_uufl
    • 2024-02-12_19:27:53.087651_lxVk
    • 2024-02-12_19:27:53.087659_JIpa
    • 2024-02-12_19:27:53.087667_aTPb
    • 2024-02-12_19:27:53.087674_CJvn
    • 2024-02-12_19:27:53.087686_FZSe
    • 2024-02-12_19:27:53.087694_TmQZ
    • 2024-02-12_19:27:53.087700_jSfY
    • 2024-02-12_19:27:53.087707_ruFr

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OPVLuofU0h/index.html

jadenlin-g pushed a commit that referenced this pull request Feb 15, 2024
@firebase firebase locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants