Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to enable test-app in subprojects.cfg #3905

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

jladieu
Copy link
Contributor

@jladieu jladieu commented Jul 15, 2022

This is to help with the error:

Project 'test-app' not found in project ':firebase-appdistribution'

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 15, 2022

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (cdd1044) to 77.17% (f2ce424) by ?.

    36 individual files with coverage change

    FilenameBase (cdd1044)Merge (f2ce424)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?30.00%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?0.00%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?92.79%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?81.08%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?95.45%?
    InstallActivity.java?2.53%?
    LogWrapper.java?53.33%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?65.63%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?96.30%?
    TesterApiHttpClient.java?88.35%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

Notes

  • Commit (f2ce424) is created by Prow via merging PR base commit (cdd1044) and head commit (31fc364).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6q0rdJoC2v.html

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Unit Test Results

139 tests  ±0   139 ✔️ ±0   42s ⏱️ +10s
  15 suites ±0       0 💤 ±0 
  15 files   ±0       0 ±0 

Results for commit 31fc364. ± Comparison against base commit cdd1044.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 15, 2022

Size Report 1

Affected Products

  • base

    TypeBase (cdd1044)Merge (f2ce424)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (cdd1044)Merge (f2ce424)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.88 kB? (?)
  • firebase-appdistribution

    TypeBase (cdd1044)Merge (f2ce424)Diff
    aar?152 kB? (?)
    apk (aggressive)?879 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (cdd1044)Merge (f2ce424)Diff
    aar?14.5 kB? (?)
    apk (aggressive)?85.5 kB? (?)
    apk (release)?697 kB? (?)
  • firebase-common

    TypeBase (cdd1044)Merge (f2ce424)Diff
    aar?48.6 kB? (?)
    apk (aggressive)?84.8 kB? (?)
    apk (release)?690 kB? (?)
  • firebase-components

    TypeBase (cdd1044)Merge (f2ce424)Diff
    aar?41.4 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?29.5 kB? (?)
  • firebase-installations

    TypeBase (cdd1044)Merge (f2ce424)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?86.4 kB? (?)
    apk (release)?712 kB? (?)
  • firebase-installations-interop

    TypeBase (cdd1044)Merge (f2ce424)Diff
    aar?8.34 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

Notes

  • Commit (f2ce424) is created by Prow via merging PR base commit (cdd1044) and head commit (31fc364).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kxfUqEd01I.html

@jladieu
Copy link
Contributor Author

jladieu commented Jul 15, 2022

/test smoke-tests

@jladieu
Copy link
Contributor Author

jladieu commented Jul 15, 2022

I'm just going to yolo merge this because it's a docs change, but it's not lost on me that the CI presubmits seem to be mad.

Bummer, I guess I can't actually because of this. Not sure where this is going to land in my priority queue, but I don't think it's at the top, so this PR might languish a bit.

Fixed by #3920

@jladieu jladieu force-pushed the jl-fixup-docs branch 3 times, most recently from fa3a6ad to 9c628e4 Compare July 19, 2022 19:53
This is to help with the error:

```
Project 'test-app' not found in project ':firebase-appdistribution'
```
@jladieu jladieu merged commit e2e41f5 into master Jul 19, 2022
@jladieu jladieu deleted the jl-fixup-docs branch July 19, 2022 20:29
@firebase firebase locked and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants