Skip to content

Add support for return values to applyToForegroundActivity() #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add support for return values to applyToForegroundActivity() #3831

merged 1 commit into from
Jun 23, 2022

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Jun 22, 2022 •
edited
Loading

The old applyToForegroundActivity() which accepted a void callback, is now called consumeForegroundActivity().

Also, adds TestUtils.mockForegroundActivity() for mocking all of these types of methods to return a given activity.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 22, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 78.21% (74c068e) to 78.28% (723d8e5) by +0.07%.

    FilenameBase (74c068e)Merge (723d8e5)Diff
    FirebaseAppDistributionLifecycleNotifier.java73.68%75.00%+1.32%

Test Logs

Notes

  • Commit (723d8e5) is created by Prow via merging PR base commit (74c068e) and head commit (7770755).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KwmnuwZe1L.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 22, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (74c068e)Merge (723d8e5)Diff
    aar146 kB146 kB+559 B (+0.4%)
    apk (release)2.01 MB2.01 MB+284 B (+0.0%)

Test Logs

Notes

  • Commit (723d8e5) is created by Prow via merging PR base commit (74c068e) and head commit (7770755).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QwGdI41JXG.html

@lfkellogg lfkellogg changed the title WIP - Take an actual screenshot for feedback Take an actual screenshot for feedback Jun 22, 2022
@lfkellogg lfkellogg force-pushed the lk/actual-screenshot branch from b30fdfb to 7770755 Compare June 22, 2022 22:37
@lfkellogg lfkellogg changed the title Take an actual screenshot for feedback Add support for return values to applyToForegroundActivity Jun 22, 2022
@lfkellogg lfkellogg changed the title Add support for return values to applyToForegroundActivity Add support for return values to applyToForegroundActivity() Jun 22, 2022
@lfkellogg lfkellogg merged commit 8b53fa5 into master Jun 23, 2022
@lfkellogg lfkellogg deleted the lk/actual-screenshot branch June 23, 2022 13:56
lfkellogg added a commit that referenced this pull request Jun 24, 2022
@lfkellogg
Revert "Support return values in applyToForegroundActivity() (#3831)"
2bd3cd4 
This reverts commit 8b53fa5.
@lfkellogg lfkellogg mentioned this pull request Jun 24, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

@jladieu jladieu Awaiting requested review from jladieu

+1 more reviewer

@rachaprince rachaprince rachaprince approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfkellogg @google-oss-bot @rachaprince @kaibolay