Database: Rename test helpers#280
Merged
schmidt-sebastian merged 1 commit intomasterfrom Mar 15, 2019
Merged
Conversation
schmidt-sebastian
force-pushed
the
mrschmidt-rename
branch
from
a2f30b1 to
f8f9ca1
Compare
Contributor
Author
|
/test connected-check-changed |
mikelehen
approved these changes
Mar 14, 2019
Contributor
mikelehen
left a comment
mikelehen
left a comment
There was a problem hiding this comment.
Well, that's one way to pad your CL stats I guess.... 😛
Contributor
Author
|
Padded (and probably a better way than #281 :/)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the component registration for the RTDB, I got super confused because we have two TestHelper files in the same package. One is used for Unit Tests and one for Integration Tests. They used to be part of the same package, but I split them up when we moved to GitHub.
This PR: