Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated inclusion of firebase-components on test-app. #1554

Merged
merged 1 commit into from
May 13, 2020
Merged

Remove duplicated inclusion of firebase-components on test-app. #1554

merged 1 commit into from
May 13, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 12, 2020

No description provided.

@rlazo rlazo requested review from ashwinraghav and VinayGuthal May 12, 2020 22:32
@googlebot googlebot added cla: yes Override cla labels May 12, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (9d75839) and head commit (066c4b27).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (066c4b27) is created by Prow via merging commits: 9d75839 2f39d03.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (9d75839) and head commit (066c4b27).

Test Logs

Notes

Head commit (066c4b27) is created by Prow via merging commits: 9d75839 2f39d03.

@rlazo rlazo requested a review from vkryachko May 13, 2020 14:37
@rlazo rlazo merged commit 386f602 into master May 13, 2020
@rlazo rlazo deleted the rl.storage-test-app branch May 13, 2020 14:59
ashwinraghav pushed a commit that referenced this pull request May 18, 2020
@rlazo @ashwinraghav
Remove duplicated inclusion of firebase-components on test-app. (#1554)
a43c017
@firebase firebase locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @VinayGuthal @googlebot