Skip to content

Remove debug print for HTTP status error#939

Merged
jonathanedey merged 2 commits intofirebase:mainfrom
Plonq:remove-debug-print
Feb 26, 2026
Merged

Remove debug print for HTTP status error#939
jonathanedey merged 2 commits intofirebase:mainfrom
Plonq:remove-debug-print

Conversation

@Plonq
Copy link
Contributor

@Plonq Plonq commented Feb 25, 2026

I have simply removed what appears to be a debugging print statement that wasn't intended to be merged. It can clutter logs with many benign HTTP 400 responses when calling send_each_async or send_each_for_multicast_async. Since the errors are returned from those functions, I don't see any value in this print statement.

@google-cla
Copy link

google-cla bot commented Feb 25, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Plonq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the application's logging behavior by eliminating an extraneous debug print statement. The removed statement was responsible for logging HTTP status errors, which, while sometimes indicative of issues, often generated unnecessary noise in the logs for expected error conditions. This change enhances log clarity and reduces verbosity without altering the core error handling logic.

Highlights

  • Logging Improvement: Removed a debug print statement that was outputting HTTP status errors, which could lead to cluttered logs, especially for benign 400 responses.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • firebase_admin/_utils.py
    • Removed a debug print statement that logged HTTP status errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes a debug print statement from the handle_httpx_error function. As noted in the pull request description, this will prevent cluttering logs with benign HTTP status errors. The change is simple, correct, and improves the maintainability of the code. I have no further comments.

Copy link
Collaborator

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @Plonq , LGTM!
Can you please sign the CLA before we merge this, thanks!

@Plonq
Copy link
Contributor Author

Plonq commented Feb 26, 2026

Thanks for catching this @Plonq , LGTM! Can you please sign the CLA before we merge this, thanks!

Done!

@jonathanedey jonathanedey merged commit 581ef26 into firebase:main Feb 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants