fix(fcm): Converting unexpected gapic runtime errors to FirebaseError #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
googleapiclientoccasionally raises low-level runtime errors, which are currently not handled in the FCM implementation. These exceptions are directly exposed to the user, who typically only expect to handle instances ofFirebaseError. This PR makes sure our FCM implementation handles all exceptions raised bygoogleapiclient, and they are correctly mapped to instances ofFirebaseError.Resolves #506
RELEASE NOTE: Correctly handling low-level runtime errors raised by the
googleapiclientpackage while sending batch requests.