- 
                Notifications
    You must be signed in to change notification settings 
- Fork 344
feat(auth): Added OIDCProviderConfig type and get/delete APIs #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            2 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -45,10 +45,26 @@ def enabled(self): | |
| return self._data['enabled'] | ||
|  | ||
|  | ||
| class OIDCProviderConfig(ProviderConfig): | ||
| """Represents the OIDC auth provider configuration. | ||
|  | ||
| See https://openid.net/specs/openid-connect-core-1_0-final.html. | ||
| """ | ||
|  | ||
| @property | ||
| def issuer(self): | ||
| return self._data['issuer'] | ||
|  | ||
| @property | ||
| def client_id(self): | ||
| return self._data['clientId'] | ||
|  | ||
|  | ||
| class SAMLProviderConfig(ProviderConfig): | ||
| """Represents he SAML auth provider configuration. | ||
|  | ||
| See http://docs.oasis-open.org/security/saml/Post2.0/sstc-saml-tech-overview-2.0.html.""" | ||
| See http://docs.oasis-open.org/security/saml/Post2.0/sstc-saml-tech-overview-2.0.html. | ||
| """ | ||
|  | ||
| @property | ||
| def idp_entity_id(self): | ||
|  | @@ -149,6 +165,15 @@ def __init__(self, http_client, project_id, tenant_id=None): | |
| if tenant_id: | ||
| self.base_url += '/tenants/{0}'.format(tenant_id) | ||
|  | ||
| def get_oidc_provider_config(self, provider_id): | ||
| _validate_oidc_provider_id(provider_id) | ||
| body = self._make_request('get', '/oauthIdpConfigs/{0}'.format(provider_id)) | ||
| return OIDCProviderConfig(body) | ||
|  | ||
| def delete_oidc_provider_config(self, provider_id): | ||
| _validate_oidc_provider_id(provider_id) | ||
| self._make_request('delete', '/oauthIdpConfigs/{0}'.format(provider_id)) | ||
|  | ||
| def get_saml_provider_config(self, provider_id): | ||
| _validate_saml_provider_id(provider_id) | ||
| body = self._make_request('get', '/inboundSamlConfigs/{0}'.format(provider_id)) | ||
|  | @@ -253,6 +278,16 @@ def _make_request(self, method, path, **kwargs): | |
| raise _auth_utils.handle_auth_backend_error(error) | ||
|  | ||
|  | ||
| def _validate_oidc_provider_id(provider_id): | ||
| if not isinstance(provider_id, str): | ||
| raise ValueError( | ||
| 'Invalid OIDC provider ID: {0}. Provider ID must be a non-empty string.'.format( | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will not check for empty strings though, will it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The immediate next check ( | ||
| provider_id)) | ||
| if not provider_id.startswith('oidc.'): | ||
| raise ValueError('Invalid OIDC provider ID: {0}.'.format(provider_id)) | ||
| return provider_id | ||
|  | ||
|  | ||
| def _validate_saml_provider_id(provider_id): | ||
| if not isinstance(provider_id, str): | ||
| raise ValueError( | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "name":"projects/mock-project-id/oauthIdpConfigs/oidc.provider", | ||
| "clientId": "CLIENT_ID", | ||
| "issuer": "https://oidc.com/issuer", | ||
| "displayName": "oidcProviderName", | ||
| "enabled": true | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we return the status 'success/failed' here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return of these delete methods are
void.