Skip to content

Firebase Ml Fix upload file naming #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 27, 2020
Merged

Firebase Ml Fix upload file naming #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fcc3b2d
Firebase ML Modify Operation Handling Code to match actual codes
ifielker Jan 23, 2020
5c923ce
apply database fix too
ifielker Jan 23, 2020
16815e2
fix create/update date handling
ifielker Jan 23, 2020
2c42847
Fix File Naming
ifielker Jan 23, 2020
8563154
merged
ifielker Jan 27, 2020
04ab98c
suggestion applied
ifielker Jan 27, 2020
fad359d
fixed lint
ifielker Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase_admin/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
16: exceptions.UNAUTHENTICATED,
}


def _get_initialized_app(app):
if app is None:
return firebase_admin.get_app()
Expand Down
5 changes: 4 additions & 1 deletion firebase_admin/ml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import datetime
import re
import time
import os
import requests
import six

Expand Down Expand Up @@ -440,8 +441,10 @@ def _parse_gcs_tflite_uri(uri):
def upload(bucket_name, model_file_name, app):
"""Upload a model file to the specified Storage bucket."""
_CloudStorageClient._assert_gcs_enabled()

file_name = os.path.basename(model_file_name)
bucket = storage.bucket(bucket_name, app=app)
blob_name = _CloudStorageClient.BLOB_NAME.format(model_file_name)
blob_name = _CloudStorageClient.BLOB_NAME.format(file_name)
blob = bucket.blob(blob_name)
blob.upload_from_filename(model_file_name)
return _CloudStorageClient.GCS_URI.format(bucket.name, blob_name)
Expand Down