Add integration tests for RC manage version operations #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note: That failing integration test is from ML. Fix is in |
hiranya911
suggested changes
Jun 23, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks mostly good. Just a few tidbits to clean up.
| }, | ||
| ]; | ||
|
|
||
| const VALID_VERSION: admin.remoteConfig.Version = { |
Contributor
There was a problem hiding this comment.
Just wondering. Are these explicit type annotations really required?
Member
Author
There was a problem hiding this comment.
I removed the type annotations for VALID_VERSION. It looks like we need the type annotation for VALID_CONDITIONS unless I use a const INDIGO: admin.remoteConfig.TagColor = 'INDIGO' for tag color.
| }); | ||
| }); | ||
|
|
||
| it('verfy that getTemplateAtVersion() returns the requested template version v2', () => { |
Member
Author
There was a problem hiding this comment.
This was to confirm that we are not getting the most recent template and having two versions confirms it. I see your point though :)
Will remove the expects here, but leave the templates for listVersions tests.
lahirumaramba
force-pushed
the
lm-rc-vc-integration
branch
from
9ad71f8 to
ca57fd4
Compare
lahirumaramba
force-pushed
the
lm-rc-vc-integration
branch
from
ca57fd4 to
28a22ff
Compare
lahirumaramba
force-pushed
the
lm-rc-vc-integration
branch
from
28a22ff to
be4d8dc
Compare
hiranya911
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listVersions,getTemplateAtVersion, androllbackoperationsversionsmetadata in Remote Config templateslistVersions, and add unit testsNote: Added
release:stageto trigger integration tests. Merging toremote-config-vcmaster.