fix: Upgraded node-forge and jsonwebtoken dependencies #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
LGTM. Left one question
| "jsonwebtoken": "8.1.0", | ||
| "node-forge": "0.7.4" | ||
| "jsonwebtoken": "^8.5.1", | ||
| "node-forge": "^0.7.6" |
Member
There was a problem hiding this comment.
Any reason why we wouldn't update this to most recent0.9.1?
Contributor
Author
There was a problem hiding this comment.
I upgraded via npm update command, and this is what was automatically picked by NPM (possibly because 0.x versions are allowed to make breaking changes between minor releases). I will test 0.9.1 and upgrade in a separate PR.
Member
There was a problem hiding this comment.
Sounds good. Thanks for checking!
lahirumaramba
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #905