Skip to content

fixing tests with unhandled promises #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ifielker merged 2 commits into from
May 19, 2020
Merged

fixing tests with unhandled promises #894

ifielker merged 2 commits into from
May 19, 2020

Conversation

@ifielker
Copy link
Contributor

@ifielker ifielker commented May 19, 2020

fixing tests with unhandled promises

@hiranya911 hiranya911 added the release:stage Stage a release candidate label May 19, 2020
hiranya911
hiranya911 approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 assigned ifielker and unassigned hiranya911 May 19, 2020
@hiranya911 hiranya911 removed the release:stage Stage a release candidate label May 19, 2020
@ifielker ifielker merged commit 6fa5219 into master May 19, 2020
@ifielker ifielker deleted the fixTest branch May 19, 2020 19:06
@henriquebonfim henriquebonfim mentioned this pull request Aug 20, 2024
Open
@k-azadzoi k-azadzoi mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ifielker ifielker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ifielker @hiranya911