Adds basic integration tests for the following in multi-tenancy context: #584
Conversation
bojeil-google
commented
Jun 25, 2019
bojeil-google
commented
- User management
- Custom claims
- Import users
- List users
- Token revocation
- Email link generation (skipped due to backend bug)
- OIDC/SAML management APIs.
- User management - Custom claims - Import users - List users - Token revocation - Email link generation (skipped due to backend bug) - OIDC/SAML management APIs.
Removes unnecessary import.
|
I want to add testing for |
test/integration/auth.spec.ts
Outdated
| .then((userRecord) => { | ||
| createdUserUid = userRecord.uid; | ||
| expect(userRecord.tenantId).to.equal(createdTenantId); | ||
| expect(userRecord.email.toLowerCase()).to.equal(newUserData.email.toLowerCase()); |
There was a problem hiding this comment.
Can we call toLowerCase() on line 515 instead?
test/integration/auth.spec.ts
Outdated
|
|
||
| it('revokeRefreshTokens() should revoke the tokens for the tenant specific user', () => { | ||
| // Revoke refresh tokens. | ||
| currentTime = new Date().getTime() - 1; |
There was a problem hiding this comment.
Perhaps add a comment to explain - 1.
There was a problem hiding this comment.
I made some changes to clarify and added comments.
test/integration/auth.spec.ts
Outdated
| .then((listUsersResult) => { | ||
| // Confirm expected user returned in the list. | ||
| let expectedUserFound = false; | ||
| listUsersResult.users.forEach((user) => { |
There was a problem hiding this comment.
Perhaps the functional style is more readable for this sort of things:
const allUsersBelongToTenant = listUsersResult.users.every(user => user.tenantId == createdTenantId);
expect(allUsersBelongToTenant).to.be.true;
const knownUserInTenant = listUsersResult.users.some(user => user.uid == createdUserUid);
expect(knownUserInTenant).to.be.true;
| const rawSalt = 'NaCl'; | ||
|
|
||
| before(() => { | ||
| tenantAwareAuth = admin.auth().forTenant(createdTenantId); |
There was a problem hiding this comment.
Can we do this outside before? Something like:
const tenantAwareAuth = admin.auth().forTenant(createdTenantId);
Here and in other similar describe blocks.
There was a problem hiding this comment.
I can't because initializeApp has to be called before I do this. We call it in before at setup: https://github.com/firebase/firebase-admin-node/blob/auth-multi-tenancy/test/integration/setup.ts#L40
It is not worth a refactor.
