Adds tenant management APIs to developer facing Auth instance. #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes getTenant, deleteTenant, listTenants, createTenant and updateTenant. This expects TenantServerResponse to be returned for createTenant and updateTenant. Expected results have not been confirmed. A followup PR will add integration tests for the above.
hiranya911
suggested changes
Jun 13, 2019
src/auth/auth.ts
Outdated
| * @return {Promise<Tenant>} A promise that resolves with the corresponding tenant. | ||
| */ | ||
| public getTenant(tenantId: string): Promise<Tenant> { | ||
| return (this.authRequestHandler as AuthRequestHandler).getTenant(tenantId) |
There was a problem hiding this comment.
You can use generics and get rid of these casts if you want to.
abstract class AbstractRequestHandler { }
class AuthRequestHandler extends AbstractRequestHandler {
public getTenant() { }
}
class TenantAwareRequestHandler extends AbstractRequestHandler { }
abstract class BaseAuth<T extends AbstractRequestHandler> {
protected requestHandler: T;
}
class Auth extends BaseAuth<AuthRequestHandler> {
public getTenant() {
// requestHandler is treated as AuthRequestHandler by the compiler
this.requestHandler.getTenant();
}
}
There was a problem hiding this comment.
Good idea. Done.
wuyanna
approved these changes
Jun 13, 2019
Adds missing backend errors.
wuyanna
approved these changes
Jun 14, 2019
hiranya911
suggested changes
Jun 14, 2019
| }; | ||
| // Stubs used to simulate underlying API calls. | ||
| let stubs: sinon.SinonStub[] = []; | ||
| afterEach(() => { |
There was a problem hiding this comment.
Nit: Add an empty line before this for clarity.
| .to.have.been.calledOnce.and.calledWith(undefined, undefined); | ||
| }); | ||
| }); | ||
|
|
| }); | ||
|
|
||
| it('should be rejected given TenantOptions with invalid property', () => { | ||
| return (auth as Auth).updateTenant(tenantId, {type: 'lightweight'}) |
There was a problem hiding this comment.
Can we make it clear what the invalid property is? Is it the key or the value that makes it invalid? Depending on the intention of the test either {invalid: 'lightweight'} or {type: 'invalid'}. If neither is appropriate, update the description of the test.
There was a problem hiding this comment.
I updated test description and added a comment here and in the createTenant test similar to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes getTenant, deleteTenant, listTenants, createTenant and updateTenant.
This expects TenantServerResponse to be returned for createTenant and updateTenant.
Expected results have not been confirmed. A followup PR will add integration tests for the above.