Skip to content

fix(auth): Add TotpInfo field to UserRecord #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pragatimodi merged 9 commits into from
Jun 27, 2023
Merged

fix(auth): Add TotpInfo field to UserRecord #2197

pragatimodi merged 9 commits into from
Jun 27, 2023

Conversation

@pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented May 26, 2023 •
edited
Loading

Adding a TotpInfo field to UserRecord for Admin users to view a user's MFA configuration. TOTP enrollment for users is enabled via client SDKs only.
Testing was done by manually enrolling a user on TOTP using curl and creating a test app to get the corresponding user's UserRecord configuration
Manual testing output:

MultiFactorSettings {
  enrolledFactors: [
    TotpMultiFactorInfo {
      uid: 'bd8fa8e0-194c-443e-82e9-77b39868aed7',
      factorId: 'totp',
      displayName: 'enroll-totp-test',
      enrollmentTime: 'Wed, 31 May 2023 20:39:18 GMT',
      totpInfo: {}
    }
  ]
}

@pragatimodi pragatimodi requested a review from renkelvin May 30, 2023 21:33
@pragatimodi pragatimodi marked this pull request as ready for review May 30, 2023 21:33
@pragatimodi pragatimodi requested a review from prameshj May 30, 2023 23:09
renkelvin
renkelvin reviewed May 30, 2023
View reviewed changes
prameshj
prameshj reviewed May 31, 2023
View reviewed changes
Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR description to describe the change and also include the manual testing done? Thanks!

@pragatimodi pragatimodi force-pushed the totp-user-record branch 2 times, most recently from fd542b0 to fa82293 Compare May 31, 2023 03:55
prameshj
prameshj reviewed May 31, 2023
View reviewed changes
@pragatimodi pragatimodi requested review from prameshj and renkelvin May 31, 2023 19:11
prameshj
prameshj approved these changes May 31, 2023
View reviewed changes
Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a snippet of the user record output in the PR description? Thanks!

@pragatimodi pragatimodi requested a review from lahirumaramba May 31, 2023 22:44
Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahirumaramba lahirumaramba changed the title Adding TotpInfo to userRecord feat(auth): Add TotpInfo field to UserRecord Jun 2, 2023
lahirumaramba
lahirumaramba reviewed Jun 5, 2023
View reviewed changes
lahirumaramba
lahirumaramba approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

This was referenced Sep 4, 2024
Closed
Closed
Closed
This was referenced Sep 13, 2024
Closed
Closed
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
jevisleey added a commit to jevisleey/vertcitronm that referenced this pull request May 19, 2025
@jevisleey
[chore] Release 11.10.0 (#2246)
b3cc73a 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
johnbabu021q2ch8h added a commit to johnbabu021q2ch8h/johnbabu021q2ch8h that referenced this pull request May 24, 2025
@johnbabu021q2ch8h
[chore] Release 11.10.0 (#2246)
fe3aec5 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
mlc250312 added a commit to mlc250312/rollupx that referenced this pull request May 27, 2025
@mlc250312
[chore] Release 11.10.0 (#2246)
770717e 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
FrancoisRibreau added a commit to FrancoisRibreau/igmoid that referenced this pull request Jun 10, 2025
@FrancoisRibreau
[chore] Release 11.10.0 (#2246)
69a4beb 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
xt000020032004 added a commit to xt000020032004/vlang that referenced this pull request Jun 10, 2025
@xt000020032004
[chore] Release 11.10.0 (#2246)
a32ecdc 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
EdwerdHill added a commit to EdwerdHill/BishopFox that referenced this pull request Jun 10, 2025
@EdwerdHill
[chore] Release 11.10.0 (#2246)
71a5088 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
DandelionFs added a commit to DandelionFs/kaimed that referenced this pull request Jun 10, 2025
@DandelionFs
[chore] Release 11.10.0 (#2246)
26f95a2 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
YaConnor pushed a commit to YaConnor/openucd that referenced this pull request Jun 11, 2025
[chore] Release 11.10.0 (#2246)
35bc2c4 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
JosephKis added a commit to JosephKis/FPGA that referenced this pull request Jun 14, 2025
@JosephKis
[chore] Release 11.10.0 (#2246)
363c1f9 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
HaydenAnder pushed a commit to HaydenAnder/shangbei that referenced this pull request Jul 3, 2025
[chore] Release 11.10.0 (#2246)
cd7f4d6 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
iThomasJohnson pushed a commit to iThomasJohnson/VDA that referenced this pull request Jul 6, 2025
[chore] Release 11.10.0 (#2246)
225662d 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
NanciiWilson added a commit to NanciiWilson/easywj that referenced this pull request Jul 7, 2025
@NanciiWilson
[chore] Release 11.10.0 (#2246)
066ac3b 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
CynghiaClark added a commit to CynghiaClark/zhangboyang that referenced this pull request Jul 14, 2025
@CynghiaClark
[chore] Release 11.10.0 (#2246)
5422d67 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
VirginialWilson added a commit to VirginialWilson/palm that referenced this pull request Jul 14, 2025
@VirginialWilson
[chore] Release 11.10.0 (#2246)
2507583 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
ChelseaAdamsen added a commit to ChelseaAdamsen/engine that referenced this pull request Jul 14, 2025
@ChelseaAdamsen
[chore] Release 11.10.0 (#2246)
aca9976 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
AlberteWilson added a commit to AlberteWilson/Banach that referenced this pull request Jul 25, 2025
@AlberteWilson
[chore] Release 11.10.0 (#2246)
c7ec879 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
MossyrockMusing added a commit to MossyrockMusing/MossyrockMusing that referenced this pull request Aug 13, 2025
@MossyrockMusing
[chore] Release 11.10.0 (#2246)
28bdfe1 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
residaes added a commit to residaes/notableBlock that referenced this pull request Oct 4, 2025
@residaes
[chore] Release 11.10.0 (#2246)
b75394c 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
gandlie added a commit to gandlie/domqueryall that referenced this pull request Oct 13, 2025
@gandlie
[chore] Release 11.10.0 (#2246)
7738714 
Includes: 
- firebase/firebase-admin-node#2216
- firebase/firebase-admin-node#2209
- firebase/firebase-admin-node#2036
- firebase/firebase-admin-node#2197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

+2 more reviewers

@renkelvin renkelvin renkelvin approved these changes

@prameshj prameshj prameshj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pragatimodi @lahirumaramba @renkelvin @prameshj @Xiaoshouzi-gh