Update Gulpfile to copy files required for generated client to properly run #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
reviewed
Jun 30, 2021
| 'src/**/protos/*.json', | ||
| // This isn't ideal, but doing something like | ||
| // 'src/generated/**/*.json' results in incorrect paths in the /lib dir | ||
| 'src/**/*.json' |
There was a problem hiding this comment.
Can we say src/generated/**/*.json instead?
There was a problem hiding this comment.
Ah I see. It ends up copying them into lib/messaging instead of lib/generated/messaging. I guess it only matches path segments after src/generated when the pattern is specified this way. Then I think the way you've implemented this is correct.
There was a problem hiding this comment.
Yeah, doing the more general wildcard is less "comfortable" than doing the specific src/generated/**/*.json, but it's (as far as I could tell) the only way for the generated path to be structured properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run buildetc. will now copy over the the.d.tsand.jsonfiles found ingenerated/messaging. Before, this didn't happen, and the generated client would error on runtime.