Reject non-standard Number classes during POJO serialization (RTDB)#262
Merged
schmidt-sebastian merged 2 commits intomasterfrom Mar 18, 2019
Merged
Reject non-standard Number classes during POJO serialization (RTDB)#262schmidt-sebastian merged 2 commits intomasterfrom
schmidt-sebastian merged 2 commits intomasterfrom
Conversation
hiranya911
approved these changes
Mar 18, 2019
| if (!existingPropertyName.equals(propertyName)) { | ||
| throw new DatabaseException( | ||
| "Found setter with invalid case-sensitive name: " + method.getName()); | ||
| "Found setter with invalid " + "case-sensitive name: " + method.getName()); |
Contributor
Author
There was a problem hiding this comment.
I removed this instance and the remaining string concatenations in this file that follow a similar pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the changes from firebase/firebase-android-sdk#272 and updates the error messages in the RTDB client when a user attempts to serialize Number types that we cannot serialize to JSON.
Addresses: #75