Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add X-Goog-Api-Client metric header to outgoing requests #430

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

jonathanedey
Copy link
Contributor

Added X-Goog-Api-Client headers to outgoing requests for metrics tracking

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Nov 5, 2024
@jonathanedey jonathanedey marked this pull request as ready for review November 5, 2024 21:30
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@@ -28,6 +28,7 @@
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<AdditionalFiles Include="../../stylecop.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what triggered this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to apply stylecop.json custom settings to test files.

@jonathanedey jonathanedey merged commit b6cf20a into master Nov 7, 2024
5 checks passed
@jonathanedey jonathanedey deleted the je-headers branch November 7, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants