Skip to content

Conversation

@CorieW
Copy link
Member

@CorieW CorieW commented Jul 15, 2025

Resolves #2476

  • Tested

@CorieW CorieW force-pushed the @invertase/add-backfill-batch-size-param branch 2 times, most recently from c527698 to 109c8fa Compare July 16, 2025 14:31
@CorieW CorieW force-pushed the @invertase/add-backfill-batch-size-param branch from 109c8fa to 626d8d8 Compare July 16, 2025 14:39
@CorieW CorieW requested a review from Copilot July 17, 2025 00:17

This comment was marked as outdated.

@CorieW CorieW marked this pull request as ready for review July 17, 2025 14:13
@CorieW CorieW requested a review from cabljac July 17, 2025 14:22
Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a configurable parameter for the backfill batch size in the storage-resize-images extension, allowing users to customize how many images are processed in a single batch during backfill operations instead of being limited to the hardcoded value of 3.

  • Adds a new BACKFILL_BATCH_SIZE parameter with a default value of 3
  • Replaces the hardcoded batch size with the configurable parameter in the backfill function
  • Updates documentation and configuration files to reflect the new parameter

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
storage-resize-images/functions/src/index.ts Replaces hardcoded maxResults value with configurable backfillBatchSize
storage-resize-images/functions/src/config.ts Adds backfillBatchSize configuration parameter with default value of 3
storage-resize-images/functions/tests/function.test.ts Updates test mock to include backfillBatchSize parameter
storage-resize-images/functions/tests/filters.test.ts Updates test mock to include backfillBatchSize parameter
storage-resize-images/functions/tests/snapshots/config.test.ts.snap Updates snapshot to include backfillBatchSize in configuration
storage-resize-images/extension.yaml Adds parameter definition and bumps version to 0.2.10
storage-resize-images/README.md Documents the new backfill batch size parameter
storage-resize-images/CHANGELOG.md Records the feature addition in version 0.2.10

@cabljac cabljac merged commit 43392d1 into next Jul 22, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [storage-resize-images] Backfill function performance

3 participants