-
Notifications
You must be signed in to change notification settings - Fork 424
feat(storage-resize-image): add param for backfill batch size #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c527698 to
109c8fa
Compare
109c8fa to
626d8d8
Compare
cabljac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a configurable parameter for the backfill batch size in the storage-resize-images extension, allowing users to customize how many images are processed in a single batch during backfill operations instead of being limited to the hardcoded value of 3.
- Adds a new
BACKFILL_BATCH_SIZEparameter with a default value of 3 - Replaces the hardcoded batch size with the configurable parameter in the backfill function
- Updates documentation and configuration files to reflect the new parameter
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| storage-resize-images/functions/src/index.ts | Replaces hardcoded maxResults value with configurable backfillBatchSize |
| storage-resize-images/functions/src/config.ts | Adds backfillBatchSize configuration parameter with default value of 3 |
| storage-resize-images/functions/tests/function.test.ts | Updates test mock to include backfillBatchSize parameter |
| storage-resize-images/functions/tests/filters.test.ts | Updates test mock to include backfillBatchSize parameter |
| storage-resize-images/functions/tests/snapshots/config.test.ts.snap | Updates snapshot to include backfillBatchSize in configuration |
| storage-resize-images/extension.yaml | Adds parameter definition and bumps version to 0.2.10 |
| storage-resize-images/README.md | Documents the new backfill batch size parameter |
| storage-resize-images/CHANGELOG.md | Records the feature addition in version 0.2.10 |
Resolves #2476